Broken after pull request

[Ryder-One]

I had a look after the pull request of @Ludofloria and everything seems pretty much broken :( At least in ruin mode, everything is messed up.

When I rollback to my previous branch it's working again.

@Ludofloria do you have a debug JSON which is not working with the previous code? Is it different than the demo mode ? Why the demo mode is all broken with your code ?

I'm thinking about rolling back your modification and release my ruin branch. Unfortunately I don't have access to an account with enough points to access the big maps, so I won't be able to test the ruin in real situation anytime soon.

If somebody can provide me JSON debug of their ruin that would be a great help but I don't even know if the map is launching when beeing in a ruin.

[Ryder-One]

I think the commits about "startVar" and walls, arrows, are all wrong for my version of the game (hordes.fr) (PR #12 ) .

Maybe for some other version it's OK but that would be a very bad news :( It's a very big mess now I've merged it, can't release like that.

Can you share with me some debug code about your ruin ? To see what are the differences.

[Ryder-One]

Just saw it's not @Ludofloria the author but rather @Matoran , I've posted on the PR

[Matoran]

17 should solve the problem, some commits are missing on your version.

[Matoran]

If by broken you mean, it's wrong directions, wrong walls/decor position the pull request will definitively fix everything.

fakeRuinDirections seems to have the same problem as the entire code, left and right are inverted. with left and right inverted:

this.fakeRuinDirections = [
                        [
                            [false, false, false, false], [false, false, false, false], [false, false, false, false], [false, false, false, false],
                            [false, false, false, false], [false, false, false, false], [false, false, false, false], [false, false, false, true],
                            [false, false, false, false], [false, false, false, false], [false, false, false, false], [false, false, false, false],
                            [false, false, false, false], [false, false, false, false], [false, false, false, false]
                        ],
                        [
                            [false, false, false, false], [false, false, false, false], [false, false, false, false], [false, false, false, false],
                            [false, false, false, true], [false, false, false, false], [true, false, false, true], [true, true, true, false],
                            [true, false, true, false], [true, false, true, false], [true, false, true, true], [true, false, true, false],
                            [false, false, true, true], [false, false, false, false], [false, false, false, false]
                        ],
                        [
                            [false, false, false, false], [false, false, false, false], [false, false, false, false], [true, false, false, true],
                            [true, true, true, false], [true, false, true, false], [false, true, true, true], [false, false, false, false],
                            [false, false, false, false], [false, false, false, false], [false, true, false, true], [false, false, false, false],
                            [true, true, false, true], [false, false, true, false], [false, false, false, false]
                        ],
                        [
                            [false, false, false, false], [false, false, false, false], [false, false, false, false], [false, true, false, true],
                            [false, false, false, false], [false, false, false, false], [true, true, false, false], [true, false, true, false],
                            [true, false, true, false], [true, false, true, false], [true, true, true, true], [true, false, true, false],
                            [false, true, true, true], [false, false, false, false], [false, false, false, false]
                        ],
                        [
                            [true, false, false, true], [true, false, true, false], [true, false, true, false], [false, true, true, false],
                            [false, false, false, false], [false, false, false, true], [false, false, false, false], [false, false, false, false],
                            [false, false, false, false], [false, false, false, false], [false, true, false, true], [false, false, false, false],
                            [false, true, false, true], [false, false, false, false], [false, false, false, false]
                        ],
                        [
                            [false, true, false, true], [false, false, false, false], [false, false, false, false], [false, false, false, false],
                            [false, false, false, false], [true, true, false, true], [true, false, true, false], [false, false, true, true],
                            [false, false, false, false], [false, false, false, false], [true, true, false, false], [true, false, true, false],
                            [true, true, true, false], [false, false, true, true], [false, false, false, false]
                        ],
                        [
                            [true, true, false, false], [true, false, true, false], [false, false, true, true], [false, false, false, false],
                            [false, false, false, false], [false, true, false, true], [false, false, false, false], [true, true, false, false],
                            [false, false, true, true], [false, false, false, false], [false, false, false, false], [false, false, false, false],
                            [false, false, false, false], [false, true, false, true], [false, false, false, false]
                        ],
                        [
                            [false, false, false, false], [false, false, false, false], [true, true, false, false], [true, false, true, true],
                            [true, false, true, false], [false, true, true, true], [false, false, false, false], [false, false, false, false],
                            [true, true, false, false], [true, false, true, true], [true, false, true, false], [false, false, true, true],
                            [false, false, false, false], [false, true, false, false], [false, false, false, false]
                        ],
                        [
                            [false, false, false, false], [false, false, false, false], [false, false, false, false], [false, true, false, false],
                            [false, false, false, false], [false, true, false, false], [false, false, false, false], [false, false, false, false],
                            [false, false, false, false], [false, true, false, false], [false, false, false, false], [false, true, false, false],
                            [false, false, false, false], [false, false, false, false], [false, false, false, false]
                        ]
                    ];```

[Ryder-One]

Oh ok thanks ! Should I take the fakeRuinDirections you just posted above ? Or did your PR corrected also the fake data ? Thanks

[Matoran]

My new PR also fix fake data :).