search

Ryder-One / hmap

An HTML5 map for Die2Nite
9 stars 3 forks source link

Added soul on grid map + Enabled HMap on Android on Mobile #5

Closed Ludofloria closed 4 years ago

Ludofloria commented 4 years ago

Hello !

I've managed to get the souls working on the grid view ;) For now, the souls are moving according to a random pattern accross 4 cases around it's location (as it is on the flash version). But the icon is not rotating well ;)

Also, I've modified the detection of the flashvars content to make HMap work on Firefox for Android ;)

Ryder-One commented 4 years ago

Hi,

Many thanks for your PR.

I'll start reviewing it now

Ryder-One commented 4 years ago

Do you think the PR will fix it : https://github.com/Ryder-One/hmap/issues/4 ?

Ludofloria commented 4 years ago

This one should fix #4 indeed ;) To add a "soul" mode on your website, you just need the decoded data from the map ;) I had some, but I lost it while pulling your latest changes :/ Maybe, next time I become Shaman I can drop the datas ;) Eventually, to add souls on the map, you just have to set to true the "_s" var in the "_details" array

Ludofloria commented 4 years ago

UPDATE : Here is a full debug data, with souls on the map https://pastebin.com/GLBpTSGN

Ryder-One commented 4 years ago

Hi, thank you for your quick answer.

By adding the "Soul" mode to the website, I meant : edit the index.html and create the checkbox to let users play with the shaman mode (that also mean generate random soul in the fake data)

Ryder-One commented 4 years ago

In the meantime, can you create a new PR with only the firefox bug correction ?

I'll be able to merge it right away.

Ludofloria commented 4 years ago

Oh okay. Yes, I'll do it later this week then ;)

Ludofloria commented 4 years ago

Here. I've updated the branch to add Shaman Mode to the website ;)

Ryder-One commented 4 years ago

Hi,

Nice job ! I will look into it to see if we can improve the souls behavior. I think I will be able to make a new release this week-end with your contribution.

Thank you

Ludofloria commented 4 years ago

Yup, it might be improved (such as the icon rotation, it is absolutely not working)

machandeze commented 3 years ago

This one should fix #4 indeed ;)

I am still experiencing #4 , but I found a quick workaround. I'm going to make a pull request.