search

Ryex / ic10emu

A Stationeers IC10 code editor and emulator
https://ic10emu.dev/
Apache License 2.0
4 stars 2 forks source link

Fix named types/modes #25

Closed Emilgardis closed 3 months ago

Emilgardis commented 3 months ago

this doesn't work currently

resolves #24 depends on #26

Emilgardis commented 3 months ago

should probably add some regression tests to catch these kind of errors, pretty sure this (as in #24) used to work correctly

Ryex commented 3 months ago

try re-basing on https://github.com/Ryex/ic10emu/tree/ensure_no_borrow_errors and see if you still have the borrow panic. you'll need to edit the batch_modes test to un-comment the line that tests the "Maximum" mode

overall I think this is a good change. we'll inevitable end up with more Enums that overlap in the future

Ryex commented 3 months ago

Just tested, seems to fix the issue now. also no panics :)