Slots inprovment - Githubissues

Ryex commented 3 months ago

improve the slots interface:

[x] make the fields collapsible
[x] display quantity with image
[x] let user search for and select occupants as well as change quantity
[x] try to make it as compact as possible (slot filter?)
[x] ~~pageify if number of slots is large (vending machine)?~~

github-actions[bot] commented 2 months ago

🚀 Deployed on https://deploy-preview-30--ic10emu.netlify.app

Ryex commented 2 months ago

@ComputerDruid @Emilgardis

next update is pretty much ready if either of you want / can help out with a review that would be great.

ComputerDruid commented 2 months ago

I should have some time to take a look today, sure!

ComputerDruid commented 2 months ago

I tried the demo and came away with some notes:

You probably want to write patch notes for this still
I can't change the ReferenceId of a IC10 chip I added to a second CircuitHousing. Not that I know why it would matter what the id of a slot occupant is, but maybe it would matter if it was using an ID I wanted to use for something else?
wow, adding a stack of coal ore to the input slot of the sorter, and seeing it rendered with the icon and the little 1/50 looks really good, very impressive.
I can add a second circuit housing and a chip to it, but it still doesn't appear in the drop-down for setting the active IC. Presumably that's just not implemented yet? Also changing the ID of the main Housing makes it so that it doesn't run anymore, but I think that was true before this PR.
wow, the device search is fast now! Presumably helped by the "too many results" page.

I tried it out with a random file I had open in a tab and was able to add stuff to the import slots and see it react (turning on the silo), so that's a good sign. link to my test script

Overall the new stuff feels really nice to use. I'm planning to look at the code later today, too.

Ryex commented 2 months ago

I tried the demo and came away with some notes:

You probably want to write patch notes for this still

absolutly

I can't change the ReferenceId of a IC10 chip I added to a second CircuitHousing. Not that I know why it would matter what the id of a slot occupant is, but maybe it would matter if it was using an ID I wanted to use for something else?

the slot occupant Id change will need to wait for a bigger rewrite I'm planning

wow, adding a stack of coal ore to the input slot of the sorter, and seeing it rendered with the icon and the little 1/50 looks really good, very impressive.

(^^)

I can add a second circuit housing and a chip to it, but it still doesn't appear in the drop-down for setting the active IC. Presumably that's just not implemented yet? Also changing the ID of the main Housing makes it so that it doesn't run anymore, but I think that was true before this PR.

I think I can fix the housing Id change, in theory I can enable multiple IC's at this point but I'd rather wait till after that bigger rewrite.

wow, the device search is fast now! Presumably helped by the "too many results" page.

Yeah, turns out rending that many dom nodes at once is slow, who knew? (I did, I just didn't consider how slow)

Overall the new stuff feels really nice to use. I'm planning to look at the code later today, too.

Thanks!

ComputerDruid commented 2 months ago

I did read through the rust code but most of this change wasn't rust (and I'm not familiar enough with js to be able to offer much insight, so I didn't try reading that). The bits I read all look good to me!

Ryex / ic10emu

Slots inprovment #30