Closed zrisher closed 7 years ago
I thought popen was evil and stole all the version numbers?
The release section is just sent straight to GitHub. I didn't want to hold the author's hand too much. You can get a new line with "\\n". That's two slashes, not the four I had to type.
Re: popen - nope, version numbers working great! I think the issue was the whole "Load ARMS is a program downloaded from the internet" thing, which is fixed now that SEPL has an installer.
Re: release body - Yep I think it's great that we can provide github release notes directly from this file, and I wouldn't want you to have to modify the input too much, but the current approach is hard to use. Don't you think this:
"release": {
"body": "Complete rewrite of radar code.\n\n * Uses real radar formula\n * Improved cooperation between radars\n * Cooperation between jammers\n * Sensors & Cameras can locate entities\n * Removed radar from autopilot block\n\nas always, contains bug fixes",
"draft": false,
"prerelease": false
},
is significantly less usable and more error-prone than this:
"release": {
"body": [
"Complete rewrite of radar code.",
"",
" * Uses real radar formula",
" * Improved cooperation between radars",
" * Cooperation between jammers",
" * Sensors & Cameras can locate entities",
" * Removed radar from autopilot block",
"",
"as always, contains bug fixes",
],
"draft": false,
"prerelease": false
},
I think they both suck. I never used the "body" field. I always just entered it through the website so I don't mind changing it.
Changes
.build
scripts and provides a plugin config file to enable using SEPL for building plugins instead of Load-ARMS.One thing to note here - the format for
release.body
inplugin.json
really sucks because JSON doesn't allow multiline strings. I think an optimal solution here would be for SEPL to alternatively accept body content as an array of lines inrelease.body_lines
.