Ryo-Seah / pe

0 stars 0 forks source link

Should not allow to schedule two event with the same client at the same time #6

Open Ryo-Seah opened 5 months ago

Ryo-Seah commented 5 months ago

When adding a scheduled appointment, it does not make sense to allow adding of a different appointment to the same person and the exact same date and time. This makes it hard to catch mistakes made when user accidentally enters wrong date/time resulting in overlapping appointments!

Steps to reproduce:

  1. Run command "schedule add h/Meeting with Client t/2/14/2024 0930 d/Discuss project details n/John Doe"
  2. Run command "schedule add h/Meeting with friend t/2/14/2024 0930 d/Discuss project details n/John Doe"

Expected output : "Error, appointment already exist with this person at this date and time"

Reason for severity : While this does not make the app unusable, it represents potential for huge issues when many appointments are stacked at the same time and date. It does not warn the user from adding mutliple appointments.

Actual output : A new appointment is added successfully. Screenshot 2024-04-19 at 4.54.11 PM.png

nus-pe-bot commented 5 months ago

Team's Response

It is possible that the social worker is meeting a group of people. For example, the social worker is meeting a group of elderly at a local Community Center event for a group therapy session (or any other reasons), in this scenario it is imperative that the social worker be able to meet with multiple clients at the same time.

This is a feature that can be added in future iterations of the applications (thus, we have changed to NotInScope).

Moreover, it is unlikely that users will be making mistakes by scheduling appointments on the same time, hence, we suggest reducing the severity to low.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I think an additional feature for group meetings is indeed out of scope. However, this bug does not refer to that. If this current version of the app is indeed meant for group meetings it would mean even greater confusion of accidental clashing appointments vs group meetings. It would make it even harder to differentiate between the two. Considering this flaw can be fixed with a simple 2 line code to check if the date and time matches exactly or matches in a 30 minute window, I do feel like it is something that should have been added to the current iteration of the app and should not be out of scope. It also does affect the appointment feature as defined in V1.4


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I don't think this could be just a rare occurrence. For team with small number of volunteers and large number of elderly, it could very well cause a sizeable number of confusions from clashing bookings. Especially since there is no way to check what appointment a volunteer has on a specific day.