RyoKosaka / HelloDrum-arduino-Library

This is a library for making E-Drum with arduino.
https://open-e-drums.com/
MIT License
244 stars 61 forks source link

Tcrt5000 hihatpedal.hit issue #57

Open DavosPegas opened 1 year ago

DavosPegas commented 1 year ago

Hello, I am getting a weird behaviour of hihat control pedal based on tcrt5000. All closed/open hihat hits works ok but pedal hit is triggered when my foot and the pedal moves up, not when it comes down to the floor. This is very unnatural. I also had to change the Open and Close notes on HiHat trigger. It seems like it works in the other direction for any reason. I checked tcrt analog read values and its fine - the smaller the gap between tcrt and pedal the smaller the value it returns. Do you have any idea what may be the reason of these "upside - down" issues?

delorimier commented 10 months ago

I ran into this problem also. Figured out a fix in hellodrum code in the hellodrum.cpp file, FSRSensing function (FSRsensing function is used with the tcrt). Swith from > to < (smaller than) on line 801, and the reverse on line 846. Revert your open/close changes. Fixed! --- edit: this has not fixed all problems, trying more changes to the function.