Ryochan7 / DS4Windows

Like those other ds4tools, but sexier
https://ryochan7.github.io/ds4windows-site/
GNU General Public License v3.0
6.98k stars 808 forks source link

Vibration on DualShok/ DualSense #2439

Closed wanted8x closed 1 year ago

wanted8x commented 2 years ago

Hi, can you Enable Vibration on DS4/DualSense Controller? ViGEmBus driver has become Update.

Your Text: Disabled broken DS4 feedback support again. Can't have semi-nice things. Don't bring it up again until at least the next ViGEmBus driver update...

Thanks for your Time

Yohoki commented 2 years ago

Noticed the first game that something is odd about. Biped. Updated my game list again.

Edit: I'm not going to be able to test with a v1 anymore... I attempted to apply a stick drift fix mod to my wife's v1 with a soldering iron that is probably older than my grandfather. While my wife may be unhappy at the outcome, I believe I've discovered that I'm so incredibly good at building bridges that I should maybe consider a career as an architect. Jokes aside, my launch edition v1 is now a pretty paperweight until I get a spare board. I'll only be using a v2 for testing games for now.

Ryochan7 commented 2 years ago

It has been a few days but I figured I should update this. The test code has been merged into the master branch.

Also, RIP Mrs. Yohoki v1 DS4

Yohoki commented 2 years ago

Aside from Biped, it's been working really well in any game I've tried. Haven't noticed any inf rumble popping back up anywhere. Lightbar seem to be supported in any game that already sends lightbar updates without d4w active. Haven't noticed any major input lag. Glad to see it making it into the main.

I wouldn't know where to begin debugging on Biped to see what's going on there, though. It's the only game I've tried that disables rumble when D4W is used, but enables it when D4W is turned off. All the other games are behaving identical whether it's virtual or HW DS4.

.

Also, RIP Mrs. Yohoki v1 DS4

It will be missed. T.T

Wifey's Pink V1 11/15/13 - 9/6/22

Kanuan commented 2 years ago

I wouldn't know where to begin debugging on Biped to see what's going on there, though. It's the only game I've tried that disables rumble when D4W is used, but enables it when D4W is turned off

  1. Test again but now Running DS4Windows under a custom ".exe" name
    • Make 100% sure the custom .exe name is being used by checking on Windows' task bar -> DETAILS tab
  2. If it's a Steam game, do the following while running DS4Windows with a custom .exe name:
    • Test with Steam PS Config. Support disabled
    • Test again with PS Config. Support enabled. Make 100% sure Steam is picking the Virtual DS4
  3. If it's the gog's version just running with custom .exe name should be enough assuming the game uses SDL2 for controller support
Yohoki commented 2 years ago
  1. Test again but now Running DS4Windows under a custom ".exe" name

Ah. Yep. That did it. Seems this game detects DS4Windows and disables rumble, even though it still detects the controller and allows you to play with it. Custom EXE name fixes it. You can tell it's working because the lightbar turns white in-game (didn't know that was a thing) and rumble starts working again.

What an odd thing, to check for DS4Windows, but not actually ban it. Either way, that fixes that game's issues. Adding info to list.

Kanuan commented 2 years ago

What an odd thing, to check for DS4Windows, but not actually ban it.

This is usually associated with using SDL2. Steam, Yuzu, CEMU, Dolphin I think in the latest versions, and some games all use SDL2 for controller support, and SDL2 itself will ignore DS4/DualSense controllers if it detects DS4Windows is running

Yohoki commented 2 years ago

But those will usually ignore the controller completely right? Biped was only disabling rumble, but letting the inputs through. And even then, the x360 worked fine, not disabling anything if d4w was running.

That's why I thought it was odd... It was ONLY rumble that was affected. Not completely disabling controllers. Either way, it seems to be fine now with custom exe names.

Kanuan commented 2 years ago

It has been a few days but I figured I should update this. The test code has been merged into the master branch

@Ryochan7 Just one comment, I think you've merged the master branch into the AwaitOutputBuffer_test and not the contrary

spookyrecharge commented 1 year ago

Can we at least have a toggle button for this somewhere in options like: Enable <=3.0.10 dualshock4 rumble support (warning: this may cause infinite rumble issue)? It sucks that we need two separate versions for the latest features and for working vibration on DS4

spookyrecharge commented 1 year ago

Nvm, just realized that with the latest release version of ViGEmBus driver everything works as expected on the latest version of DS4Windows. I just didn't know that we ever need to update ViGEmBus driver manually (I'm always using DS4Updater to upgrade DS4Windows). Maybe add a possibility to upgrade ViGEmBus driver using DS4Updater? It can be useful for someone too

soredake commented 1 year ago

@spookyrecharge there is ViGEmBus_Updater task in task scheduler that will check for updates and prompt you to update if new version is found.

nefarius commented 1 year ago

ViGEmBus ships with an auto updater now so no need.

whoisalireza commented 1 year ago

Hey, can you add audio support for the Dualsense while connected via bluetooth? That would be extremely cool!

nefarius commented 1 year ago

Hey, can you add audio support for the Dualsense while connected via bluetooth? That would be extremely cool!

Kindly refrain from hijacking closed threads with unrelated topics, thanks.

whoisalireza commented 1 year ago

Hey, can you add audio support for the Dualsense while connected via bluetooth? That would be extremely cool!

Kindly refrain from hijacking closed threads with unrelated topics, thanks.

Sorry, I was viewing this thread from the mobile app and didnt know any other way to comment. The app is not very helpful with this.

kulkarni005 commented 1 year ago

Just in case, if you are still struggling with activating vibration on ds controller. Enable Copycat option from settings->device options->detected controller