Ryochan7 / DS4Windows

Like those other ds4tools, but sexier
https://ryochan7.github.io/ds4windows-site/
GNU General Public License v3.0
7k stars 808 forks source link

[Request] Multi-Action Button - Scan Code option #26

Closed paulo-lima-dev closed 7 years ago

paulo-lima-dev commented 7 years ago

So I requested this back when J2K was still around. He did planned to add this in a future release but the development stoped before he release it. So just a request for consideration.

Also would be great of stead of just macros "Multi-Action Button" would also show the full "select a action screen" with the keyboard/mouse/gamepad and the macros options.

Thanks for all the updates! Cheers!

Ryochan7 commented 7 years ago

The scan code option is considered deprecated since keyboard events use both virtual key and scan code information by default; the scan code option might be removed in the future. Scan codes should be sent for multi-action button actions in recent releases of DS4Windows. The current scan code option only acts as a way to only send a scan code without the corresponding virtual key. Based on my experience, fake keyboard events really should contain both a virtual key and a scan code in all circumstances.

paulo-lima-dev commented 7 years ago

Humm them I think the Multi-Action Button is just not working ;)

Ryochan7 commented 7 years ago

I broke it. The current state was being compared against itself.

paulo-lima-dev commented 7 years ago

Unfortunately without the "Scan Code" option in the Multi-Action Button some games do not detect the input. Skyrim for instance is quite a mess and sometimes it only detects inputs with "scan code" enable.

So I would greatly appreciated this option to be considered ;) Maybe it could be ported from the "record macro" special action

Ryochan7 commented 7 years ago

Skyrim for instance is quite a mess

That is all that needed to be said. Anyway, it might be better if you shared the profile you are using to play Skyrim. Based on my experience, that is one game where you have to make the choice to play with either KB+M controls or full gamepad controls. You cannot use a mixed mode configuration without running into some major problems. It makes using the Steam Controller on Skyrim a much bigger hassle than it should be.

When using pure KB+M controls with DInput only enabled in a profile to unplug the virtual XInput controller, a Multi-Action button macro works perfectly fine in game. Also, the expected code path is being run.

Ryochan7 commented 7 years ago

I would also need your Actions.xml file.

paulo-lima-dev commented 7 years ago

Sorry for the late response! Here is my profile and special actions. Skyrim Profile Action For Skyrim there is a SKSE dll to improve Gamepad features and circunvent the engine limitations. The plugin is a must for gamepad users: Better Mouse and Gamepad support (an SKSE Plugin)

paulo-lima-dev commented 7 years ago

Did some more testings and the issue is not related to Scan code ;) Some combinations are just too fast for the Apps to detect them. So using the "Record Delays" will fix most of the issues!

Ryochan7 commented 7 years ago

That is one big reason that I do not use the macro system. A system more like Xpadder for making complex assignments would have been better.

On Oct 7, 2017 1:39 PM, "pralima87" notifications@github.com wrote:

Did some more testings and the issue is not related to Scan code ;) Some combinations are just too fast for the Apps to detect them. So using the "Record Delays" will fix most of the issues!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Ryochan7/DS4Windows/issues/26#issuecomment-334957207, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjhUI_7gXYHP6_n-vOm0WmPfS9MypCIks5sp8VkgaJpZM4NL4X9 .