Closed rnhmjoj closed 3 years ago
I have never run any of the test suite. Maybe I should but it has not been a big deal to me. Anyway, the changes look good and have been merged in. Thank you for the changes.
I have never run any of the test suite.
Yeah, I figured. The python builder in Nixpkgs runs tests by default, so that's why I'm insisting with these. Would it be possible to make a new release with the tests working?
Got a new release out now. There was one small change that had to be made to fix the test suite on my Fedora box.
https://github.com/Ryochan7/sc-controller/releases/tag/v0.4.8.6
Great! Thank you.
Fix the tests after changes related to the VDF parser and remainders. Take a look at the commit messages for more explanations.