search

Ryochan7 / sc-controller

User-mode driver and GTK3 based GUI for Steam Controller
GNU General Public License v2.0
177 stars 23 forks source link

Fix all tests #39

Closed rnhmjoj closed 3 years ago

rnhmjoj commented 3 years ago

Fix the tests after changes related to the VDF parser and remainders. Take a look at the commit messages for more explanations.

Ryochan7 commented 3 years ago

I have never run any of the test suite. Maybe I should but it has not been a big deal to me. Anyway, the changes look good and have been merged in. Thank you for the changes.

rnhmjoj commented 3 years ago

I have never run any of the test suite.

Yeah, I figured. The python builder in Nixpkgs runs tests by default, so that's why I'm insisting with these. Would it be possible to make a new release with the tests working?

Ryochan7 commented 3 years ago

Got a new release out now. There was one small change that had to be made to fix the test suite on my Fedora box.

https://github.com/Ryochan7/sc-controller/releases/tag/v0.4.8.6

rnhmjoj commented 3 years ago

Great! Thank you.