Ryochan7 / sc-controller

User-mode driver and GTK3 based GUI for Steam Controller
GNU General Public License v2.0
176 stars 23 forks source link

fix half of the controls not working on steam deck #92

Closed Dark3clipse closed 1 year ago

Dark3clipse commented 1 year ago

In this PR I reverted to the old way of swapping old_state and _input variables. For some reason the "new" way makes half the SD controls non-functional.

I kept the gyro groll inversion. I tested it with yuzu and Kirby and the forgotten land in the minigame and the gyro seems correct.

The only difficulty I still had was that for some reason with my SD the yaw updates with a rather large lag of ~2 seconds. I don't know if this is related to my hardware or whether more people have this problem.

See this for reference https://user-images.githubusercontent.com/220973/166127234-a5ad1faa-ac6b-419a-beed-5b478ecd5f16.jpg

Teracube_20230712_173202_757

Solves

91

Ryochan7 commented 1 year ago

I'll get the change merged later. Not sure why the Yaw would lag behind the Roll or Pitch. I think I have mainly tested it with the DS4 and I did not experience a problem like that with CemuHook (using PadTest app in Wine). I can only assume it is something specific to the steamdeck module.

Edit: Remembered later that I have tested CemuHook with the Steam Controller in the past

Ryochan7 commented 1 year ago

So much for getting this merged quickly. I am spread too thin online and AFK. Thank you for fixing Steam Deck mapping.