search

Ryosuke839 / UnicodePad

An Android App that enables input every character in Unicode
https://play.google.com/store/apps/details?id=jp.ddo.hotmist.unicodepad
Apache License 2.0
314 stars 32 forks source link

F-Droid can't build anymore since `com.google.android.gms:play-services-ads(-lite)` are not open-source. #48

Closed lfourquaux closed 3 years ago

lfourquaux commented 4 years ago

F-Droid can't build anymore since com.google.android.gms:play-services-ads(-lite) are not open-source.

Originally posted by @licaon-kter in https://github.com/Ryosuke839/UnicodePad/issues/17#issuecomment-605900019

The F-Droid version is increasingly outdated, it would be nice to have a fully open source, up to date version of UnicodePad.

TPS commented 4 years ago

@Ryosuke839 What's needed is a flavor to include only what's acceptable to build for F-droid.

@licaon-kter, @Izzysoft: Any pointers on how to do such would be much appreciated. 🙇🏾‍♂️

IzzySoft commented 4 years ago

I'm neither dev nor packager – so the only advice I can give is check with other apps which have done that (setting up separate flavors). In our *.yml files you can tell them by using gradle with a specific name, e.g.

gradle:
  - foss

foss and fdroid are quite common with those, so a egrep '^\s*- (fdroid|foss)' *.yml should help identifying them.

t-8ch commented 3 years ago

@Ryosuke839 Would you accept a pullrequest for such a build variant?

Ryosuke839 commented 3 years ago

@t-8ch Yes! I will definitely accept on this repo once I validate the behavior.

t-8ch commented 3 years ago

@Ryosuke839 Thanks! @TPS Welp, I managed to mess up the PR, it should against the repo of @Ryosuke839 obviously :-)

TPS commented 3 years ago

@t-8ch You mentioned a problem in your PR, anyway. Probably better to fix there than PR here until it's resolved? Or not: https://github.com/Ryosuke839/UnicodePad/pull/74

t-8ch commented 3 years ago

@TPS it's more of a validation issue. I expect it to actually work, but for some reason the Ads are not shown at all for me, even in the origin version. If any changes are necessary I can do those in this PR easily.

TPS commented 3 years ago

@IzzySoft Now that #74 is merged, is anything else needed to have F-Droid start publishing this again?

t-8ch commented 3 years ago

I think the timeline would be:

linsui commented 3 years ago

2.9.1 will be published soon. See https://monitor.f-droid.org/builds/running. When the next release available please open an MR the update the build recipe.