RyotaUshio / obsidian-pdf-plus

PDF++: The most Obsidian-native PDF annotation, viewing & editing tool ever. Comes with optional Vim keybindings.
https://ryotaushio.github.io/obsidian-pdf-plus/
MIT License
855 stars 18 forks source link

Mobile experience #217

Open RyotaUshio opened 5 months ago

RyotaUshio commented 5 months ago

Hi, I hope y'all enjoying this plugin.

This plugin was original created primarily for the desktop app, and therefore its mobile support has been incomplete. However, recently I got a necessary environment for mobile debugging, and am planning to squash the mobile-specific bugs and unnatural behaviors.

I'd love to hear your opinion - feel free to report any weirdness you experienced on mobile. I personally don't use Obsidian on mobile devices extensively, so your feedback will be greatly appreciated.


The following issues is already known, and will be fixed in the next release have already been fixed in 0.40.5:

tprotopopescu commented 5 months ago

Thank you for fixing this so quickly! The annotation pop up now comes up with a short tap on an annotation written to the pdf, but I cannot activate the context menu any more. Both the PDF++ custom menu and the new "show context menu on tablet devices" are enabled, but only the default obsidian menu comes up after selection.

Also the color of a highlight is not saved to the pdf on mobile. The annotation is saved, copying, pasting, linking etc. works, but the color is not saved to the pdf - the color shows up correctly in a callout in the markdown file, if pasted.

The screen recording shows both things:

https://github.com/RyotaUshio/obsidian-pdf-plus/assets/24751076/048218f0-500e-45b5-b96d-34ca9e551f59

RyotaUshio commented 5 months ago

@tprotopopescu Thank you for the detailed response!

What kind of device are you on? It looks like an Android smartphone, not a tablet (like iPad). I will assume so in the following, but correct me if I'm wrong.


I cannot activate the context menu any more

This is an intended change. From 0.40.5, tapping on the OS-default "Copy" menu will execute the PDF++ command "Copy link to selection or annotation", and this function is supposed to replace the role of the context menu.

the new "show context menu on tablet devices" are enabled

As in the description under the "Context menu in PDF viewer" header, now the context menu is shown only on desktop & tablet. And "tablet" does not include smartphones (I'm sorry if it was not clear).

image

It would be better if we had some means to open the context menu on smartphones as well, but so far, I have not figured it out. (Maybe I can add a new icon in the toolbar for context menu?)


the color of a highlight is not saved to the pdf on mobile.

Hmm. it looks weird. Did you tap on the color palette or the "Copy" menu?

Also, could you provide the following information so that I can look into the issue?

  1. Two copies of the same PDF file, one without annotation, and another with the added annotation.
  2. PDF++ debug info: From the command palette, run the command "PDF++: Copy debug info", and paste the result here.
tprotopopescu commented 5 months ago

I apologise, that was my misunderstanding I just jumped in and started trying things out! Yes, you are right, this is on an Android phone. I see how it works now.

For the color I tapped on the color palette, on the button for green. This is only happening on one device (samsung galaxy note 20 ultra) but the color shows up as expected on a tablet (lenovo m8).

Here is a file that this happens with: Unannotated:

Blackburn and van Benthem - Modal Logic, a Semantic Perspective.pdf

With annotation, the first two paragraphs should be highlighted:

Blackburn and van Benthem - Modal Logic, a Semantic PerspectiveAnnotated.pdf

Here is the debug info (sorry the code block is not preserving the indentation, I figure it is easier to read like this):

{ "settings": { "displayTextFormats": [ { "name": "Title & page", "template": "{{file.basename}}, p.{{pageLabel}}" }, { "name": "Page only", "template": "p.{{pageLabel}}" }, { "name": "Text", "template": "{{text}}" }, { "name": "Citekey Page", "template": "<% tp.frontmatter.citekey %> p {{pageLabel}}" }, { "name": "Bare link", "template": "go" } ], "defaultDisplayTextFormatIndex": 3, "syncDisplayTextFormat": false, "syncDefaultDisplayTextFormat": false, "copyCommands": [ { "name": "Quote in Callout", "template": "\n##### {{pageLabel}}\n\n>[!{{calloutType}}] {{linkWithDisplay}}\n> {{text}} [@<% tp.frontmatter.citekey %> p {{pageLabel}}]\n> \n>> [!annotation] Notes\n>>{{linkWithDisplay}}\n>> <% tp.file.cursor(1) %>\n>>\n^<% tp.frontmatter.citekey.toLowerCase() %>-p{{pageLabel}}-{{String(linktext.match(/=\d+,\d+,\d+,\d+|\d+R/g)).replace(/=(\d+),\d+,(\d+),\d+|(\d+)R/g,\"$1-$2$3\")}}\n\n" }, { "name": "Beginning", "template": "##### {{pageLabel}}\n\n>[!{{calloutType}}|{{colorName}}] {{linkWithDisplay}}\n> {{text}} \n}}}join{{{\n" }, { "name": "Middle", "template": "}}}join{{{\n> {{text}} {{linkWithDisplay}}\n}}}join{{{\n\n!{{link}}" }, { "name": "End", "template": "}}}join{{{\n> {{text}} [@<% tp.frontmatter.citekey %> p {{pageLabel}}]\n> \n>> [!annotation] Notes\n>> {{linkWithDisplay}}\n>> <% tp.file.cursor(1) %>\n>>\n^<% tp.frontmatter.citekey.toLowerCase() %>-p{{pageLabel}}-{{String(linktext.match(/=\d+,\d+,\d+,\d+|\d+R/g)).replace(/=(\d+),\d+,(\d+),\d+|(\d+)R/g,\"$1-$2$3\")}}\n" }, { "name": "Quote", "template": "> {{selection}} [@<% tp.frontmatter.citekey %> p {{pageLabel}}]\n" }, { "name": "Callout", "template": "> [!{{calloutType}}|{{colorName}}] {{linkWithDisplay}}\n> {{text}}" }, { "name": "Embed", "template": "!{{link}}" }, { "name": "Link only", "template": "{{linkWithDisplay}}" } ], "useAnotherCopyTemplateWhenNoSelection": true, "copyTemplateWhenNoSelection": "{{linkToPageWithDisplay}}", "trimSelectionEmbed": true, "embedMargin": 50, "noSidebarInEmbed": true, "noSpreadModeInEmbed": true, "embedUnscrollable": false, "singleTabForSinglePDF": true, "highlightExistingTab": false, "existingTabHighlightOpacity": 0.5, "existingTabHighlightDuration": 0.75, "paneTypeForFirstPDFLeaf": "", "openLinkNextToExistingPDFTab": true, "openPDFWithDefaultApp": false, "openPDFWithDefaultAppAndObsidian": true, "focusObsidianAfterOpenPDFWithDefaultApp": false, "syncWithDefaultApp": false, "dontActivateAfterOpenPDF": true, "dontActivateAfterOpenMD": true, "highlightDuration": 0.75, "noTextHighlightsInEmbed": false, "noAnnotationHighlightsInEmbed": true, "persistentTextHighlightsInEmbed": true, "persistentAnnotationHighlightsInEmbed": false, "highlightBacklinks": true, "selectionBacklinkVisualizeStyle": "highlight", "dblclickEmbedToOpenLink": true, "highlightBacklinksPane": true, "highlightOnHoverBacklinkPane": true, "backlinkHoverColor": "", "colors": { "Yellow": "#2eb837", "Red": "#ea5252", "Note": "#086ddd", "Important": "#bb61e5" }, "defaultColor": "Yellow", "defaultColorPaletteItemIndex": 1, "syncColorPaletteItem": false, "syncDefaultColorPaletteItem": false, "colorPaletteInToolbar": true, "noColorButtonInColorPalette": true, "colorPaletteInEmbedToolbar": false, "quietColorPaletteTooltip": false, "showStatusInToolbar": true, "highlightColorSpecifiedOnly": false, "doubleClickHighlightToOpenBacklink": true, "hoverHighlightAction": "preview", "paneTypeForFirstMDLeaf": "tab", "singleMDLeafInSidebar": true, "alwaysUseSidebar": true, "ignoreExistingMarkdownTabIn": [], "defaultColorPaletteActionIndex": 0, "syncColorPaletteAction": false, "syncDefaultColorPaletteAction": false, "proxyMDProperty": "file", "hoverPDFLinkToOpen": false, "ignoreHeightParamInPopoverPreview": true, "filterBacklinksByPageDefault": false, "showBacklinkToPage": true, "enableHoverPDFInternalLink": true, "recordPDFInternalLinkHistory": true, "alwaysRecordHistory": true, "renderMarkdownInStickyNote": true, "enablePDFEdit": true, "author": "**", "writeHighlightToFileOpacity": 0, "defaultWriteFileToggle": true, "syncWriteFileToggle": true, "syncDefaultWriteFileToggle": true, "enableAnnotationDeletion": true, "warnEveryAnnotationDelete": false, "warnBacklinkedAnnotationDelete": true, "enableAnnotationContentEdit": true, "enableEditEncryptedPDF": true, "pdfLinkColor": "#04a802", "pdfLinkBorder": false, "replaceContextMenu": true, "showContextMenuOnMouseUpIf": "always", "contextMenuConfig": [ { "id": "action", "visible": true }, { "id": "selection", "visible": true }, { "id": "write-file", "visible": true }, { "id": "annotation", "visible": true }, { "id": "modify-annotation", "visible": true }, { "id": "link", "visible": true }, { "id": "text", "visible": true }, { "id": "search", "visible": true }, { "id": "speech", "visible": false }, { "id": "page", "visible": true }, { "id": "settings", "visible": true } ], "selectionProductMenuConfig": [ "copy-format", "display", "color" ], "writeFileProductMenuConfig": [ "copy-format", "display", "color" ], "annotationProductMenuConfig": [ "copy-format", "display" ], "updateColorPaletteStateFromContextMenu": true, "mobileCopyAction": "pdf-plus", "showContextMenuOnTablet": true, "executeBuiltinCommandForOutline": true, "executeBuiltinCommandForZoom": true, "executeFontSizeAdjusterCommand": true, "closeSidebarWithShowCommandIfExist": true, "autoHidePDFSidebar": false, "defaultSidebarView": 2, "outlineDrag": true, "outlineContextMenu": true, "outlineLinkDisplayTextFormat": "{{file.basename}}, {{text}}", "outlineLinkCopyFormat": "{{linkWithDisplay}}", "recordHistoryOnOutlineClick": true, "popoverPreviewOnOutlineHover": true, "thumbnailDrag": true, "thumbnailContextMenu": true, "thumbnailLinkDisplayTextFormat": "{{file.basename}}, page {{pageLabel}}", "thumbnailLinkCopyFormat": "{{linkWithDisplay}}", "recordHistoryOnThumbnailClick": true, "popoverPreviewOnThumbnailHover": true, "annotationPopupDrag": true, "showAnnotationPopupOnHover": true, "useCallout": true, "calloutType": "highlight", "calloutIcon": "text-quote", "highlightBacklinksInEmbed": false, "highlightBacklinksInHoverPopover": false, "highlightBacklinksInCanvas": false, "clickPDFInternalLinkWithModifierKey": true, "clickOutlineItemWithModifierKey": false, "clickThumbnailWithModifierKey": true, "focusEditorAfterAutoPaste": false, "clearSelectionAfterAutoPaste": true, "respectCursorPositionWhenAutoPaste": false, "autoCopy": false, "autoFocus": false, "autoPaste": false, "autoFocusTarget": "last-paste-then-last-active-and-open", "autoPasteTarget": "last-paste", "openAutoFocusTargetIfNotOpened": true, "howToOpenAutoFocusTargetIfNotOpened": "tab", "closeHoverEditorWhenLostFocus": true, "closeSidebarWhenLostFocus": true, "openAutoFocusTargetInEditingView": true, "executeCommandWhenTargetNotIdentified": true, "commandToExecuteWhenTargetNotIdentified": "switcher:open", "autoPasteTargetDialogTimeoutSec": 20, "autoCopyToggleRibbonIcon": true, "autoCopyIconName": "highlighter", "autoFocusToggleRibbonIcon": true, "autoFocusIconName": "zap", "autoPasteToggleRibbonIcon": true, "autoPasteIconName": "clipboard-paste", "viewSyncFollowPageNumber": false, "viewSyncPageDebounceInterval": 0.3, "openAfterExtractPages": true, "howToOpenExtractedPDF": "tab", "warnEveryPageDelete": true, "warnBacklinkedPageDelete": true, "extractPageInPlace": false, "askExtractPageInPlace": true, "pageLabelUpdateWhenInsertPage": "keep", "pageLabelUpdateWhenDeletePage": "keep", "pageLabelUpdateWhenExtractPage": "keep", "askPageLabelUpdateWhenInsertPage": true, "askPageLabelUpdateWhenDeletePage": true, "askPageLabelUpdateWhenExtractPage": true, "copyOutlineAsListFormat": "{{linkWithDisplay}}", "copyOutlineAsListDisplayTextFormat": "{{text}}", "copyOutlineAsHeadingsFormat": "{{text}}\n\n{{linkWithDisplay}}", "copyOutlineAsHeadingsDisplayTextFormat": "p.{{pageLabel}}", "copyOutlineAsHeadingsMinLevel": 1, "newFileNameFormat": "{{folder}}/Annotations", "newFileTemplatePath": "Templates/AnnotationFile.md", "newPDFLocation": "current", "newPDFFolderPath": "", "rectEmbedStaticImage": true, "rectImageFormat": "data-url", "rectImageExtension": "webp", "zoomToFitRect": false, "rectEmbedResolution": 100, "includeColorWhenCopyingRectLink": true, "backlinkIconSize": 65, "showBacklinkIconForSelection": true, "showBacklinkIconForAnnotation": true, "showBacklinkIconForOffset": true, "showBacklinkIconForRect": true, "showBoundingRectForBacklinkedAnnot": false, "hideReplyAnnotation": false, "searchLinkHighlightAll": "true", "searchLinkCaseSensitive": "true", "searchLinkMatchDiacritics": "default", "searchLinkEntireWord": "false", "dontFitWidthWhenOpenPDFLink": true, "preserveCurrentLeftOffsetWhenOpenPDFLink": false, "defaultZoomValue": "page-width", "scrollModeOnLoad": 0, "spreadModeOnLoad": 0, "hoverableDropdownMenuInToolbar": true, "zoomLevelInputBoxInToolbar": false, "popoverPreviewOnExternalLinkHover": false, "actionOnCitationHover": "pdf-plus-bib-popover", "anystylePath": "", "enableBibInEmbed": true, "enableBibInHoverPopover": true, "enableBibInCanvas": false, "removeWhitespaceBetweenCJChars": true, "vim": true, "vimrcPath": ".obsidian.vimrc", "vimVisualMotion": true, "vimScrollSize": 40, "vimLargerScrollSizeWhenZoomIn": true, "vimContinuousScrollSpeed": 1.2, "vimSmoothScroll": true, "vimHlsearch": true, "vimIncsearch": true, "enableVimInContextMenu": true, "enableVimOutlineMode": true, "vimSmoothOutlineMode": true, "vimHintChars": "hjklasdfgyuiopqwertnmzxcvb", "vimHintArgs": "all", "PATH": "" }, "styleSettings": { "pdf-plus@@hide-pdf-embed-toolbar": true, "pdf-plus@@pdf-plus-rect-highlight-opacity": 0.78 }, "styleSheet": ".pdf-plus-backlink-highlight-layer .pdf-plus-backlink:not(.hovered-highlight)[data-highlight-color=\"yellow\"],\n.pdf-embed[data-highlight-color=\"yellow\"] .textLayer .mod-focused {\n --pdf-plus-color: #2eb837;\n --pdf-plus-backlink-icon-color: #2eb837;\n --pdf-plus-rect-color: #2eb837;\n}\n.pdf-plus-backlink-highlight-layer .pdf-plus-backlink:not(.hovered-highlight)[data-highlight-color=\"red\"],\n.pdf-embed[data-highlight-color=\"red\"] .textLayer .mod-focused {\n --pdf-plus-color: #ea5252;\n --pdf-plus-backlink-icon-color: #ea5252;\n --pdf-plus-rect-color: #ea5252;\n}\n.pdf-plus-backlink-highlight-layer .pdf-plus-backlink:not(.hovered-highlight)[data-highlight-color=\"note\"],\n.pdf-embed[data-highlight-color=\"note\"] .textLayer .mod-focused {\n --pdf-plus-color: #086ddd;\n --pdf-plus-backlink-icon-color: #086ddd;\n --pdf-plus-rect-color: #086ddd;\n}\n.pdf-plus-backlink-highlight-layer .pdf-plus-backlink:not(.hovered-highlight)[data-highlight-color=\"important\"],\n.pdf-embed[data-highlight-color=\"important\"] .textLayer .mod-focused {\n --pdf-plus-color: #bb61e5;\n --pdf-plus-backlink-icon-color: #bb61e5;\n --pdf-plus-rect-color: #bb61e5;\n}\n.pdf-plus-backlink-highlight-layer .pdf-plus-backlink:not(.hovered-highlight) {\n --pdf-plus-color: #2eb837;\n --pdf-plus-backlink-icon-color: #2eb837;\n --pdf-plus-rect-color: #2eb837;\n}\n.pdf-plus-backlink-highlight-layer .pdf-plus-backlink.hovered-highlight {\n\t--pdf-plus-color: green;\n\t--pdf-plus-backlink-icon-color: green;\n --pdf-plus-rect-color: green;\n}\n.pdf-plus-color-palette-item[data-highlight-color=\"yellow\"] > .pdf-plus-color-palette-item-inner {\n background-color: #2eb837;\n}\n.pdf-plus-color-palette-item[data-highlight-color=\"red\"] > .pdf-plus-color-palette-item-inner {\n background-color: #ea5252;\n}\n.pdf-plus-color-palette-item[data-highlight-color=\"note\"] > .pdf-plus-color-palette-item-inner {\n background-color: #086ddd;\n}\n.pdf-plus-color-palette-item[data-highlight-color=\"important\"] > .pdf-plus-color-palette-item-inner {\n background-color: #bb61e5;\n}\n.pdf-plus-color-palette-item:not([data-highlight-color]) > .pdf-plus-color-palette-item-inner {\n background-color: transparent;\n}\n.workspace-leaf.pdf-plus-link-opened.is-highlighted::before {\n\topacity: 0.5;\n}\nbody {\n --pdf-plus-yellow-rgb: 46, 184, 55\n}\nbody {\n --pdf-plus-red-rgb: 234, 82, 82\n}\nbody {\n --pdf-plus-note-rgb: 8, 109, 221\n}\nbody {\n --pdf-plus-important-rgb: 187, 97, 229\n}\nbody {\n --pdf-plus-default-color-rgb: var(--pdf-plus-yellow-rgb)\n}\n.callout[data-callout=\"highlight\"][data-callout-metadata=\"yellow\"] {\n\t--callout-color: var(--pdf-plus-yellow-rgb);\n background-color: rgba(var(--callout-color), var(--pdf-plus-highlight-opacity, 0.2))\n}\n.callout[data-callout=\"highlight\"][data-callout-metadata=\"red\"] {\n\t--callout-color: var(--pdf-plus-red-rgb);\n background-color: rgba(var(--callout-color), var(--pdf-plus-highlight-opacity, 0.2))\n}\n.callout[data-callout=\"highlight\"][data-callout-metadata=\"note\"] {\n\t--callout-color: var(--pdf-plus-note-rgb);\n background-color: rgba(var(--callout-color), var(--pdf-plus-highlight-opacity, 0.2))\n}\n.callout[data-callout=\"highlight\"][data-callout-metadata=\"important\"] {\n\t--callout-color: var(--pdf-plus-important-rgb);\n background-color: rgba(var(--callout-color), var(--pdf-plus-highlight-opacity, 0.2))\n}\n.callout[data-callout=\"highlight\"] {\n\t--callout-color: var(--pdf-plus-default-color-rgb);\n background-color: rgba(var(--callout-color), var(--pdf-plus-highlight-opacity, 0.2))\n}\n.callout[data-callout=\"highlight\"] {\n --callout-icon: lucide-text-quote;\n}" }

tprotopopescu commented 5 months ago

While testing out the color annotations I have noticed some more weirdness with writing to pdf on mobile. In most cases the file size shrinks. However I tried out one file that went from 37.8mb to 1.4gb!

This happens on both my mobile devices, but not on desktop.

Initially the file is 37.8mb, I write an annotation to the pdf file, and the file size starts to increase and over the next couple of minutes it grows to 1.4gb, the pdf reader is unresponsive while this is happening.

If I add another annotation, or delete the one I did before, the file size drops to 370mb and then grows again to 1.4gb over the next few minutes. This seems to happen with large files (the file attached above https://github.com/RyotaUshio/obsidian-pdf-plus/issues/217#issuecomment-2163184968 actually shrank, from 35kb to 25kb).

Here is a link to the original file: File

And here is a link to the expanded file: Expanded File

tprotopopescu commented 5 months ago

I have been trying out the context menu on a tablet, and on my device I am getting two context menus popping up, one after selecting the first word which remains on screen, and then another when finishing the selection:

https://github.com/RyotaUshio/obsidian-pdf-plus/assets/24751076/907ff5fd-be5e-40e0-ae1f-d7fbf96145eb

SSamDav commented 5 months ago

In Ipad I can highlight papers, I can take create a square with a copied link but I cant highlight. Also the stylus support is not so good.

https://github.com/RyotaUshio/obsidian-pdf-plus/assets/7989188/b38316dd-4935-4697-9240-367da9a77a24

RyotaUshio commented 5 months ago

@tprotopopescu Thank you again for the detailed reply! I will look into the issues. Much appreciated.

RyotaUshio commented 5 months ago

@SSamDav Thanks for the feedback, but unfortunately I cannot understand you. What did you mean by "I can highlight papers, ... but I cant highlight."? It would be much easier for me to understand the issue if you could provide the detailed steps that you followed, the expected result, and what actually happened unexpectedly.

Also the stylus support is not so good.

PDF++ is built on top of Obsidian's native PDF viewer, so I think it's Obsidian or PDF.js (the library behind the native viewer) that has to be improved.

SSamDav commented 5 months ago

@RyotaUshio sorry I meant I can't highlight the text 😅, so I must be honest I really dont know how highlight should work, I expected that when I select a color and then select a piece of text the text is highlighted but that doesn't work neither on desktop neither on mobile. If i first select the text and then select the color it highlight on desktop but not on ipad. Moreover, I tried various combinations on ipad and I cant highlight text there 😓

tprotopopescu commented 5 months ago

For what it is worth, regarding file size changing when writing to pdf (https://github.com/RyotaUshio/obsidian-pdf-plus/issues/217#issuecomment-2163298478) I tried a few more files. It seems to happen pretty reliably with books (200+ pages) bigger than 5mb, files smaller than that, having either fewer pages or smaller in size, tend to shrink in size.

tprotopopescu commented 5 months ago

@SSamDav This might help (https://forum.obsidian.md/t/selecting-text-in-pdf-android-client-is-broken/81278/6) with the stylus selection, and selection in general. It seems that pdf.js, and/or obsidian's implementation of it, does not do well with selecting text when the zoom level is not one of the defaults. When I zoom in, more than 'fit to width' and try to select the selection area jumps around randomly. Going back to 'fit to width' makes selecting text better. I hope this gets fixed soon since it makes reading some pdfs on a phone in portrait mode almost impossible.

SSamDav commented 5 months ago

@tprotopopescu Thanks for the information! But my problem is not in the selection part is more on trying to highlight the selected text 😂

1222A commented 5 months ago

QQ图片20240625071719

1222A commented 5 months ago

in ipad ,it can't be loaded

RyotaUshio commented 5 months ago

@1222A I can't reproduce it. I can install it both on my iPhone & iPad without any problem. Check your internet connection, ensure your iPadOS and Obsidian are up-to-date, and retry in the sandbox vault. If the problem persists, feel free to open a bug report following the template.

RyotaUshio commented 5 months ago

@SSamDav If you haven't, check out the docs.

tjg23 commented 5 months ago

I have no idea what could be behind this but immediately when I enable the plugin on my iPad, I can no longer scroll in Obsidian with the trackpad on my Magic Keyboard. I am on the public beta of iPadOS 17.6, so I’ll try rolling back to the last main release OS version before I open a bug report

spdc-elm commented 5 months ago

On my HuaWei Mate30 Pro (Harmony OS 4.2), color rendering doesn't work well.

The first picture was taken from my phone, where the toolbar cannot display the color button, and those underlined texts cannot be displayed properly as well. The second one was taken from my laptop. Really hope you can fix this problem! I really like this plugin which helps me a lot and save my time. Screenshot_20240705_103403_md obsidian

图片

lwzbr commented 4 months ago

I have no idea what could be behind this but immediately when I enable the plugin on my iPad, I can no longer scroll in Obsidian with the trackpad on my Magic Keyboard. I am on the public beta of iPadOS 17.6, so I’ll try rolling back to the last main release OS version before I open a bug report

I am experiencing this issue on iPadOS 17.5.1 as well.

Edit: Although enabling PDF++ causes this issue everywhere in my vault, there seems to be a problem with the Obsidian PDF viewer in general as I cannot use the Magic Keyboard touchpad or a mouse to scroll any PDFs that I’ve opened in Obsidian.

tprotopopescu commented 2 months ago

Is anyone else finding text selection on mobile does not work very well (the selection jumps around, is extremely sensitive etc.)?

This is an obsidian issue, not a pdf++ one, but if you are finding this please consider adding to this bug report on the obsidian forum (https://forum.obsidian.md/t/selecting-in-pdf-is-very-buggy-and-sporadic-in-windows-surface/84491/2) .

RyotaUshio commented 2 months ago

@tjg23 @lwzbr The scrolling issue on iPad will be fixed in the next version! (#265) Sorry for the inconvenience.

StarRain-XY commented 1 month ago

Thank you so much for developing this nice plugin and having willing to support mobile devices. the problem i met is that I can select and click copy to copy plugin' format on my iPad. However, when i use my Android device (tablet and phone), i select a sentence and click copy, it would just copy the original text instead of text with format (i already have chosen run PDF++ copy command in copy on mobile setting). More interestingly, if i choose obsidian default in copying on mobile setting, it will copy with the obsidian default format. PS. to deal with this problem now, i use commander plugin and add a button on the tab title bar to run the command 'copy link to selection'. if anyone meet same problem, you can try it.

Dennyyusuf commented 1 week ago

Hi All,

Has anyone managed to make PDF++ work effectively on an Android phone? I'm using a Samsung Z Fold 6, and I'm experiencing issues with the highlighting function. The text selection is unreliable, as it frequently misplaces the selection point from where it should be.

RyotaUshio commented 1 week ago

@Dennyyusuf Your issue seems to be this bug of the Obsidian core, not this plugin. https://forum.obsidian.md/t/selecting-in-pdf-is-very-buggy-and-sporadic/84491/8

By the way, I'm getting a used Android device soon for testing. Hopefully I will be able to take a closer look at Android specific issues.