RyotaUshio / obsidian-pdf-plus

The most Obsidian-native PDF annotation, viewing & editing tool ever. Comes with optional Vim keybindings.
https://ryotaushio.github.io/obsidian-pdf-plus/
MIT License
673 stars 13 forks source link

Canvas #43

Open RyotaUshio opened 7 months ago

RyotaUshio commented 7 months ago

Interesting: https://forum.obsidian.md/t/make-a-better-pdf-annotation-in-canvas/61298

Currently, PDF++ does not support Canvas because internal links in canvas files are not indexed by Obsidian. However, it would be possible to highlight backlinks from the same canvas file that the PDF viewer is embedded in by inventing the wheel.

We could also add a new option such as "create a card from text selection" in Canvas.

RyotaUshio commented 7 months ago

Research memo: when opening a canvas file with PDF,

app.workspace.activeLeaf.view.canvas.nodes.values().next().value.child

is a PDFEmbed instance.

diehl commented 6 months ago

@RyotaUshio +100 for the "Create card from text selection" concept

RyotaUshio commented 1 month ago

Datacore 0.1.17 has added experimental canvas indexing! https://github.com/blacksmithgu/datacore/releases/tag/0.1.17

I guess now I don't have to implement the tedious indexing part myself. Maybe this issue can be moved forward on top of this datacore update? (also contributions are welcomed)