search

RypoFalem / ArmorStandEditor

Bukkit plugin to allow players to edit armorstands without commands.
GNU General Public License v2.0
19 stars 69 forks source link

If Armorstand is Citizens NPC , Player need permission "asedit.citizens" #15

Closed mankan000 closed 6 years ago

mankan000 commented 6 years ago

When I locked armorstand as private with EntityLWC , Players can't talk to armorstand using BetonQuest plugin. But, public locking or without locking, Everyone can Edit ArmorStand. So, I add permission "asedit.citizens" It given for OP by default. It id needed to edit armorstands as Citizens NPC

RoboMWM commented 6 years ago

This PR is broken. You uploaded a class file and stuck in a new plugin.yml.

As for whether this should be added - I'm not sure what issue you're trying to resolve. You want players to interact with an armorstand, which is acting as an NPC? If this solution requires a dependency, I'm against it and would rather it be either integrated in the citizens/"betonquest" plugin or as an addon.

RypoFalem commented 6 years ago

The protection systems creates multiple events to ask for permission from other plugins before changing the armorstand. If none of those events are canceled, my plugin has to assume that no plugin had an issue with the player modifying the armorstand.

What you described is an interaction between LWC and ASE which sounds like it's working as intended:

  1. When set to private cannot edit
  2. When set to public or no protection can edit

You described an interaction between LWC and BetonQuest, and I am not sure how that is relevant.

You didn't describe what this issue with Citizens was.

I agree with what @RoboMWM said. I don't see any reason to accept this PR and for future reference: you should add the source .java files to your repository, almost never .class binaries.