search

RypoFalem / ArmorStandEditor

Bukkit plugin to allow players to edit armorstands without commands.
GNU General Public License v2.0
19 stars 69 forks source link

fix for lectern destroy event #18

Closed jascotty2 closed 5 years ago

jascotty2 commented 5 years ago

Fixes false lectern close event errors:

[13:30:50 ERROR]: Could not pass event InventoryCloseEvent to ArmorStandEditor v1.13-21
java.lang.ClassCastException: org.bukkit.craftbukkit.v1_14_R1.block.CraftBlockState cannot be cast to org.bukkit.block.Lectern
        at net.minecraft.server.v1_14_R1.TileEntityLectern$LecternInventory.getOwner(TileEntityLectern.java:57) ~[patched_1.14.2.jar:git-Paper-70]
        at org.bukkit.craftbukkit.v1_14_R1.inventory.CraftInventoryLectern.getHolder(CraftInventoryLectern.java:15) ~[patched_1.14.2.jar:git-Paper-70]
        at org.bukkit.craftbukkit.v1_14_R1.inventory.CraftInventoryLectern.getHolder(CraftInventoryLectern.java:7) ~[patched_1.14.2.jar:git-Paper-70]
        at io.github.rypofalem.armorstandeditor.PlayerEditorManager.onPlayerMenuClose(PlayerEditorManager.java:276) ~[?:?]
        at com.destroystokyo.paper.event.executor.MethodHandleEventExecutor.execute(MethodHandleEventExecutor.java:37) ~[patched_1.14.2.jar:git-Paper-70]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[patched_1.14.2.jar:git-Paper-70]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.14.2.jar:git-Paper-70]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:536) ~[patched_1.14.2.jar:git-Paper-70]
        at org.bukkit.craftbukkit.v1_14_R1.event.CraftEventFactory.handleInventoryCloseEvent(CraftEventFactory.java:1332) ~[patched_1.14.2.jar:git-Paper-70]
        at net.minecraft.server.v1_14_R1.EntityPlayer.closeInventory(EntityPlayer.java:1247) ~[patched_1.14.2.jar:git-Paper-70]
        at net.minecraft.server.v1_14_R1.EntityPlayer.tick(EntityPlayer.java:368) ~[patched_1.14.2.jar:git-Paper-70]
        at net.minecraft.server.v1_14_R1.WorldServer.entityJoinedWorld(WorldServer.java:579) ~[patched_1.14.2.jar:git-Paper-70]
        at net.minecraft.server.v1_14_R1.World.a(World.java:895) ~[patched_1.14.2.jar:git-Paper-70]
        at net.minecraft.server.v1_14_R1.WorldServer.doTick(WorldServer.java:354) ~[patched_1.14.2.jar:git-Paper-70]
        at net.minecraft.server.v1_14_R1.MinecraftServer.b(MinecraftServer.java:1177) ~[patched_1.14.2.jar:git-Paper-70]
        at net.minecraft.server.v1_14_R1.DedicatedServer.b(DedicatedServer.java:418) ~[patched_1.14.2.jar:git-Paper-70]
        at net.minecraft.server.v1_14_R1.MinecraftServer.a(MinecraftServer.java:1060) ~[patched_1.14.2.jar:git-Paper-70]
        at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:904) ~[patched_1.14.2.jar:git-Paper-70]
RoboMWM commented 5 years ago

Sounds like this bug should be reported to spigot's issue tracker IMO

RypoFalem commented 5 years ago

This is certainly something that needs to be reported to spigot team. For now, the only practical effect of the bug on my plugin is that it prints an exception to console; it doesn't change the expected behavior of the plugin because in the cases where it runs into the exception it would have done nothing anyway.

I can't stress enough that I appreciate that you took the time to track down the issue, report it and make a fix. However, because 1) the bug doesn't negatively affect plugin behavior (other than the exception reported on console) and 2) I expect the server issue to be fixed promptly if reported to spigot, I don't see any reason to accept this PR.

If you'd like to add anything, I reported the spigot issue here https://hub.spigotmc.org/jira/browse/SPIGOT-5058

jascotty2 commented 5 years ago

Thanks for putting in a report for me! :)

I didn't feel like putting the energy into properly documenting it, so many other things to fix and work on right now, and this little change was to keep these generally benign errors out of my console so they don't distract from actual issues. Put in the PR to share, and I think reporting it was the next best thing to actually fixing the issue (Since it stems from net.minecraft.server.v1_14_R1.EntityPlayer.closeInventory, it didn't look like a simple fix)