RypoFalem / ArmorStandEditor

Bukkit plugin to allow players to edit armorstands without commands.
GNU General Public License v2.0
19 stars 67 forks source link

Use Spigot API for Action Bar messages #23

Closed Puremin0rez closed 4 years ago

Puremin0rez commented 4 years ago

The current method of sending action bar messages involves executing a command from console for each player (which is universally compatible, but janky). This leads to a ton of spam for OPs and Console if your server has many players who use the editor. Instead, we use the proper api located in Spigot, which breaks compatibility with Craftbukkit.

It's my understanding after reading some comments that you are against using the Spigot API, so I don't have high hopes for this being pulled, but since I will be using it for my own fork anyways I figured I may as well.

It should be noted that Craftbukkit isn't even (easily) obtainable for most users anymore - Spigot build tools no longer builds Craftbukkit binaries by default, and users must opt to have them compiled.

If we are to believe bStats - 53.7% of servers run Spigot, 31.7% of servers run Paper - both contain this API. That means at least 85.4% of servers (who report metrics) would have this API.

Regardless of your opinion, I thank you for creating the best armor stand editor for survival players. I've used it for years and love it.

RoboMWM commented 4 years ago

What I'd do is either a) turn this into an event, or b) make it so that it's backwards-compatible with CB. I do either depending on the project (though I mostly use Paper and thus do b).

RypoFalem commented 4 years ago

https://github.com/RypoFalem/ArmorStandEditor/commit/4767b12e9cde9651475c29c61a64967f3cd2daf7