search

Rysias / cds-assignments

Assignments for Visual Analytics and Language Analytics (see relevant folders)
0 stars 0 forks source link

Assignment feedback - Network analysis #4

Open rdkm89 opened 2 years ago

rdkm89 commented 2 years ago

Great work as usual, no notes. I like your use of SOLID principles, it's nice to see you've given the code thought rather than just hammering out an easy solution!

One minor comment, you forgot to include type hints for this function:

https://github.com/Rysias/cds-assignments/blob/f59960b6f45a9b3698fa1c334a7984036c2c6045/language-a3/network_analysis.py#L31

rdkm89 commented 2 years ago

Also, this script appears to be empty:

https://github.com/Rysias/cds-assignments/blob/f59960b6f45a9b3698fa1c334a7984036c2c6045/language-a3/src/add_measures.py