Rythe-Interactive / Rythe-Engine

Rythe is a data-oriented C++17 game engine built to make optimal use of modern hardware.
https://rythe-interactive.com
MIT License
528 stars 25 forks source link

__cdecl should be replaced by ARGS_CCONV #15

Closed Algo-ryth-mix closed 4 years ago

Algo-ryth-mix commented 4 years ago

I would recommend introducing a new macro #define ARGS_CCONV __cdecl as we might want different calling conventions on different platforms (i.e.: __fastcall on windows)

it should also be part of ARGS_API such that .dll or .so are consistent across the board

GlynLeine commented 4 years ago

good point, I agree