search

Rythe-Interactive / Rythe-Engine

Rythe is a data-oriented C++17 game engine built to make optimal use of modern hardware.
https://rythe-interactive.com
MIT License
528 stars 25 forks source link

Subfeature/serialization framework #384

Closed GlynLeine closed 2 years ago

GlynLeine commented 2 years ago

I might've missed more, there's a lot of code in this PR which makes it very difficult to review it thoroughly. Try to make smaller PRs in the future as it may improve code quality.

yeah i know, this is a very old branch that snowballed. that's why i rly wanted to marge it and get rid of it so we could go back to smaller branches again

GlynLeine commented 2 years ago

@LeonBrands please not that this PR does not merge into develop

LeonBrands commented 2 years ago

I realised - I'd still want to see the issues I mentioned get fixed - the less problems to fix on the develop merge in the future the better.

GlynLeine commented 2 years ago

I realised - I'd still want to see the issues I mentioned get fixed - the less problems to fix on the develop merge in the future the better.

oh yeah i definetely agree! also ofc the build and analyze issues