search

Ryujinx / Ryujinx

Experimental Nintendo Switch Emulator written in C#
https://www.ryujinx.org
MIT License
33.51k stars 3.86k forks source link

[Feature Request] Make Controller's Screenshot Button Take Screenshot #5952

Open AsteroidPizza39 opened 8 months ago

AsteroidPizza39 commented 8 months ago

Overview

Implement the ability for a Switch controller's built-in screenshot button to take a screenshot when pressed

Smaller details

Could be added as an option in the controller configuration menu

Nature of request

N/A

Why would this feature be useful?

This would make it easier to take screenshots in Ryujinx without having to reach over to your keyboard, and it would increase parity between Ryujinx and HOS.

gdkchan commented 8 months ago

This is sort of a duplicate of #3875, although the user did not write a proper request there so I'd rather keep this open and close the other one.

RupeeClock commented 3 months ago

I am aware of some use cases for supporting the Capture button, along with the Switch system's process of generating screenshots (and video captures) when pressing the capture button.

First is that some games have custom watermarking for when an in-game capture is taken, such as Hyrule Warriors Age of Calamity, and many Square Enix titles. Example screenshot from real hardware: 2020112422084900-D7BD945BC12F73CA28E54763B2FCE27F

Second is that some games will control when the user is allowed to take captures. For example, the ending for Dragon Quest XI S: Echoes of an Elusive Age prohibits taking captures.

Third is that some games are aware of when the player is taking a capture and can respond accordingly. Mega Man Battle Network Legacy Collection Vol 1 and Vol 2 feature a character (MegaMan.exe) on the main menu, which reacts when the player takes a screenshot by pressing the Capture button and strikes a pose. Example video capture from real hardware (audio delay present): https://github.com/Ryujinx/Ryujinx/assets/24753760/c7136a5a-4e06-49f9-94ac-d7f9dfa20e89

JP-Garcia commented 2 weeks ago

I think this would be a great addition, and it sounds fairly simple to map the button to f8 in Settings > Input. I get that the switch treats the button slightly special in some games, but all people want is the ability to take a screenshot without trying to find f8 in the middle of a battle / cool moment, as well as avoid using extra controller mapping software for one button.