S-101-Portrayal-subWG / Working-Documents

16 stars 5 forks source link

Features with undefined portrayal #125

Closed DavidGrant-NIWC closed 9 months ago

DavidGrant-NIWC commented 1 year ago

A search of the 1.1.0 PC shows that the following elements portray with the testPCB symbol which indicates that the portrayal is yet to be defined:

Feature Spatial Type Issue
FloatingDock point
LandRegion curve PC Issue 235 (closed)
Pontoon point
RescueStation surface PC Issue 235 (closed)
UpdateInformation all #78
TDYCARHugh commented 1 year ago

LandRegion curve could be portrayed similar to surface with the featureName shown at the center.

alvarosanuy commented 1 year ago

FloatingDock and Pontoon do not have geometric primitive Point in S-57. What's the use case now? The use of point symbols would significantly exaggerate their footprint. If the product is the largest scale available to navigate in, then I would say the product is not good enough. Larger compilation scale is required. If larger scale product exists then the feature should be generalised out and not kept as a Point. Having said this, I recognise S-57 always had a Point symbol for Hulk.......... not sure how much it has been used though (ask RENCs to do search??)

image image

alvarosanuy commented 1 year ago

LandRegion curve could be portrayed similar to surface with the featureName shown at the center.

Agree - Can the name follow the curvature at the middle point???

alvarosanuy commented 1 year ago

RescueStation Surface can be portrayed as we did with CoastGuardStation. I believe we did not use a boundary, we just positioned the Point symbol (in this case it would be RSCSTA02) in the middle of the polygon.

MikusRL commented 1 year ago

Having said this, I recognize S-57 always had a Point symbol for Hulk.......... not sure how much it has been used though (ask RENCs to do search??)

Currently there are 631 objects encoded as HULKES. 66 of them are using Point geometry. Around 3/4 of point objects are encoded intending to portray Pontoons of various kinds (reading INFORM attribute) - either pontoons for gas/fuel stations/barges, or as floating docks for mooring, with numbers, or used for other port facility functions like club houses or museums, or just saying "Pontoon". This information most likely is intended to be used for planning purposes as stretches from band 3 to band 5. Most used in band 4 and 5, one encoding in band 2 (no other info) and one in band 6 (museum).

alvarosanuy commented 1 year ago

Decisions made at Portrayal subWG meeting on 10/5/23

  1. NIWC - Implement LandRegion Curve symbolisation similar to Surface with the featureName shown at the center.
  2. NIWC - Implement RescueStation as per CoastGuardStation but using RSCSTA02 in the middle of the polygon.
  3. Alvaro - to create new GitHub issues for FloatingDock and Pontoon and refer them to the NCWG for discussion.
  4. Close this issue once 1. and 2. are implemented.
TomRichardson6 commented 1 year ago

All

A Land Region of type curve has been added to TDS05 to support testing of this issue.

https://github.com/iho-ohi/S-101-Test-Datasets/tree/main/dev/cells/101AA00DS0005/5

DavidGrant-NIWC commented 1 year ago

We need a featureName attribute on the new feature to support portrayal.

Just to clarify, we will never see the LandRegion curve, we will only see a label (if present).

image

TomRichardson6 commented 10 months ago

Test Dataset 0005 Edition 6 has been updated so that a feature name is present on the Curve Land Region. Please confirm and close the issue if appropriate.

https://github.com/iho-ohi/S-101-Test-Datasets/tree/main/dev/cells/101AA00DS0005/6

DavidGrant-NIWC commented 10 months ago

This issue shouldn't be closed until all undefined symbols are resolved, or this issue is replaced with individual issues. Even though this is labeled for PC 1.2.0, the following two changes didn't require an updated FC so we implemented support in PC 1.1.2 via PC Issue 235:

LandRegion with curve geometry:

image

RescueStation with surface geometry:

image

with Pick Report: image

alvarosanuy commented 9 months ago

Recommend closing this issue as all components are either, already implemented or managed via other PsWG GitHub issues as follows:

Feature Spatial Type Issue
FloatingDock point PC Issue 141 (Open)
LandRegion curve Implemented in PC 1.1.2
Pontoon point PC Issue 142 (Open)
RescueStation surface Implemented in PC 1.1.2
UpdateInformation all PC Issue 78 (Closed)
" all PC Issue 151 (Open)
" all PC Issue 152 (Open)
alvarosanuy commented 9 months ago

Decisions made at Portrayal subWG meeting on 17/10/23

All features reported in this issue are either, already implemented in the PC or being actively managed via other GitHub issues.