S-101-Portrayal-subWG / Working-Documents

16 stars 5 forks source link

QoBD should evaluate depth range #127

Closed DavidGrant-NIWC closed 5 months ago

DavidGrant-NIWC commented 1 year ago

QoBD should evaluate DRVAL1 and DRVAL2 when present to exclude portrayal of QoBD features which do not apply to the mariners currently selected safety contour.

Need guidance regarding the following

  1. What should happen to the inactive QoBD features (the ones which don't intersect the safety contour value) regarding portrayal and pick report? We need to choose one of the following:

    • Assigning NullInstruction in portrayal will make them invisible but they will show in the pick report.
    • Not emitting any drawing instruction will make them invisible and exclude them from the pick report.
  2. The current guidance in the DCEG has the potential to create a discontinuity at the minimum value of the topmost QoBD feature. Most of the QoBD features must satisfy DRVAL1 < safety contour <= DRVAL2, but the topmost QoBD feature must satisfy DRVAL1 <= safety contour <= DRVAL2. To eliminate this discontinuity, suggest liaison with the DCEG group:

    • [x] Clarify that DRVAL1 is disallowed (must be null) on the topmost QoBD feature for a given date range.
    • [x] Clarify that DRVAL2 is disallowed (must be null) on the bottommost QoBD feature for a given date range.
    • [x] Highlight the inclusive / exclusive properties of DRVAL1 and DRVAL2 so that it’s clear for all encoders:
      • Applicable when the date range is active and [(DRVAL1 is null) or (DRVAL1 < safety contour)] and [(DRVAL2 is null) or (safety contour <= DRVAL2)]
  3. Suggest liaison with test group to get supporting test data developed:

    • Adjoining and overlapping QoBD with adjoining and overlapping date ranges on the individual features
    • To include the necessary swept area(s)
  4. Should this issue be brought to the attention of the doc and FC group so that the PS can be updated to include guidance for OEM’s regarding display of QoBD in the legend?

alvarosanuy commented 1 year ago

image

alvarosanuy commented 1 year ago

Decisions made at Portrayal subWG meeting on 10/5/23

TomRichardson6 commented 1 year ago

@alvarosanuy understood re the creation of a New S-164 Test label and I will raise this with the S-164 sub group.

alvarosanuy commented 10 months ago

@DavidGrant-NIWC - Have you progressed this topic with the DCEGsWG? Refer to actions above

DavidGrant-NIWC commented 10 months ago

Sorry, dropped the ball on this. It looks like I asked you via email to ask Jeff to update it, and you asked me to create a DCEG issue 😀

Added now as https://github.com/iho-ohi/S-101-Documentation-and-FC/issues/91

alvarosanuy commented 10 months ago

@DavidGrant-NIWC - All good, thanks!

@JeffWootton - Would you be able to squeeze this one into your report to S101PT11?

DavidGrant-NIWC commented 5 months ago

Believe this can be closed - implemented as PC 285

alvarosanuy commented 5 months ago

Implemented in Pc 1.2.0