Closed DavidGrant-NIWC closed 8 months ago
I will register them now because, at S101PT10 meeting, it was decided to explore the possibility for KHOA et al. to do a back end bulk SVG update to all the symbols registered in the GI Registry.
- [ ] @DavidGrant-NIWC or @MikusRL - Can you produce and upload Engineering Drawings for SAFCON70 to SAFCON 99?
@DavidGrant-NIWC @MikusRL - Can you assist with this?
We haven't generated these drawings before so it would take us a while. We'd appreciate if @MikusRL could generate them...
@alvarosanuy I did not realized that there are 30 symbols. I made the first today. Pasting its image here.
Please comment. @DavidGrant-NIWC Have I understood and drawn it correctly? I got confused a bit now about the pivot point... is it correct that it is still 0,0?, and then the symbol is shifted from it, as in the drawing shown? Because that is stated in the .svg, that pivot point is 0,0. And the measurements I take after loading this image in the S-100 Toolkit's Symbol builder tool:
The original S-57 drawing mentions pivot point as Pivot point column: 0.65 and Pivot point row: 1.25, but I understand that with the S-100 svgs the pivot point noting is different, or is it the coordinate reference which is different for the S-100 svgs, and the pivot point should be indicated from the S-100 svgs agreed reference point. Please clarify someone to make these rdawings correct. Thanks.
There really is no "pivot point" concept in SVG. In S-52 the DAI could specify a pivot point, but in S-100 the symbols should always be designed so that the pivot point is at (0, 0). See S-100 9-B-2-1:
It looks like the drawing may not be 100% accurate, but I suspect this is also the case for existing drawings. For instance, the distance from the pivot point to the center of the black line on the left of the symbol should be 3.52mm - the drawing shows 3.5mm. The width of the black line is 0.32mm, and the width of the blue line is 0.96mm. I can't tell what the 0.25mm labels in the drawing are supposed to represent.
The SAFCON symbols are designed so that the pivot point is in the (approximate) center of the label. The label is composed of one or more of the SAFCONXX
symbols. Which symbols are used is determined by the number of digits in the label.
I didn't include the fractional symbols in the following table (SAFCON5X
and SAFCON6X
):
# of digits in label | Symbols used to create label | Pivot point | Depth Range |
---|---|---|---|
1 | SAFCON0X |
Center of SAFCON0X |
[0 to 10) |
2 | SAFCON2X ,SAFCON1X |
between 2X and 1X | [10 to 100) |
3 | SAFCON8X ,SAFCON0X ,SAFCON9X |
center of 0X | [100 to 1,000) |
4 | SAFCON3X ,SAFCON2X ,SAFCON1X ,SAFCON7X |
between 2X and 1X | [1,000 to 10,000) |
5 | SAFCON4X ,SAFCON3X ,SAFCON2X ,SAFCON1X ,SAFCON7X |
between 2X and 1X | [10,000 to 100,000) |
So, if you were to lay the following SVG symbols on top of one another: SAFCON33
,SAFCON22
,SAFCON11
,SAFCON70
, it should result in the label "3210" drawn to the screen, with the geographic position of the label (pivot point) between the digits "2" and "1".
@DavidGrant-NIWC Thank you for your excellent feedback! Looking at the rest of the SAFCON symbols I managed to figured that out. That is why I did set the question if the pivot point should be other this time than just 0,0. Based on the fact that the pivot point is defined in the S-100 itself and is constant I suggest we remove that line from the drawing to remove the possible mis-definition of it. It does not give any additional information, as you commented above.
I will make sure I read the values precisely when adding them to the drawings, thanks.
One suggestion though for the future - perhaps to ease a little bit the registration and focus on the svg itself more - we could state that the engineering drawings are not the official "truth" but gives only appreciation of the symbol - its general extents, supposed look in exaggerated scale (500% at the moment used throughout) and the supposed position in regards to the point where it is or will be defined, be it a part of the labels center point or the defined point geometry, or the areas center of gravity, etc. And the normative or the "to be used" always would be the .svg itself. The .svgs with the S-100 are free accessible vs the S-52 library, so should be no objections from that perspective, and it would drive the machine readability focus too. Once someone spots the mistake and gives feedback, it is fixed in the svg and everyone benefits, and in most cases I would hope that the drawing then would not need to be updated, as the general look and feel of the symbol could be not changed in the process - more efficient upgrading and maintenance of the symbols then possible. Your thoughts and can we go ahead with such a concept already now, or would there be needed some change of the texts in S-100. We could easily add the note in the GI registry that the drawing is only informative or indicative and the svg is normative and to be used in implementation.
In general I agree with your suggestions, but any changes to the symbol registration process would have to be discussed with @JeffWootton and @alvarosanuy, and should be handled outside of this issue. I'm not sure what the appropriate repo would be, so I guess it would have to be via email.
It looks like the drawing may not be 100% accurate, but I suspect this is also the case for existing drawings. For instance, the distance from the pivot point to the center of the black line on the left of the symbol should be 3.52mm - the drawing shows 3.5mm. The width of the black line is 0.32mm, and the width of the blue line is 0.96mm. I can't tell what the 0.25mm labels in the drawing are supposed to represent.
I looked through all the svgs, and it looks like they are supposed to be in series, but they are not very "clean" in the way to be also drawn up to the 1/100 of a mm. It would not make a good sense to show all the precise precise mm as they are encoded right now. They either need to be cleaned and harmonized within their series (there are three series as I understand) or we can assume that they are good as they are encoded as no one would be able to make a distinction on screen of a 1/100 of a mm, and I would then create drawings which shows that harmony within the series - rounded up to 1/10 of a mm for the distance from the coordinate starting point (or called as a pivot point in other sense...). Otherwise the drawings would look like requiring fixing. And I will exclude the very small dimensions from the drawings, as I can not portray these dimensions so they are understandable and readable, again for the same reason - the svg is available and machine readable. No one will try to recreate the symbols manually from the drawings if they can just download and use the svgs.
The SAFCON90 misses one edge for the black line of the "0".
All three "4" symbols are larger than the rest of the numbers. the SAFCON04 in the S-52 Annex A drawing shows that it should be the same external size as the rest of the symbols. Is that intentional for these new symbols that they are bigger, and that is expected to be shown in the drawings too?
The SAFCON90 "0" is also thinner - only 1.2mm. Please when you review the lines for it make sure it is also 1.25mm, and its side edges are straight. Thanks.
@alvarosanuy I have created the drawings. Please do the spot check to confirm all is ok. I have made the drawings as per above considerations and comments. I have not updated the svg files. Four svg files need to be updated to match the drawings - SAFCON90, SAFCON74, SAFCON84, SAFCON94. SAFCON70-99 drawings.zip
Four svg files need to be updated to match the drawings - SAFCON90, SAFCON74, SAFCON84, SAFCON94.
Symbol(s) | Issue | SVG needs update | Drawing needs update |
---|---|---|---|
SAFCON71 ,SAFCON91 |
Right edge of symbol is clipped | Y | Y |
SAFCON74 ,SAFCON84 ,SAFCON94 |
DAI file doesn't match S-52 appendix1 | N | Y |
SAFCON76 |
Top edge of symbol is clipped in the drawing | N | Y |
SAFCON90 |
Currently matches the S-52 DAI file, but should be updated to match the drawing2 | Y | Y |
SAFCON90
is the only "zero" that doesn't match the others. The ENCWG should be notified of the discrepancy, and we should update our SAFCON90
to match the other "zeros".If @alvarosanuy agrees, I recommend that:
SAFCON71
, SAFCON90
, and SAFCON91
.SAFCON71
, SAFCON90
, and SAFCON91
once the symbols are updated.SAFCON74
, SAFCON84
, and SAFCON94
to match the symbols (1.55mm wide, 2.98mm tall).@alvarosanuy Sorry for the long delay in finishing this task. I trust I can find the time to do this during this week.
@DavidGrant-NIWC where can I find your updated SAFCON71, SAFCON90 and SAFCON91 svgs please? Or could you upload them here in a new .zip please? Thanks.
@MikusRL you can grab the updated symbols from the S-101 PC: https://github.com/iho-ohi/S-101_Portrayal-Catalogue/tree/main/PortrayalCatalog/Symbols
@alvarosanuy I have updated the drawings as per the David's two last points. My apologies for late execution. SAFCON71 74 84 90 91 94.zip
[ ] @DavidGrant-NIWC to notify ENCWG of issues noted above.
Has this been done?
Apart from that it seems the PC should be complete by now (?)
I'm still in the process of registering the new symbols in the GI Registry.
[ ] @DavidGrant-NIWC to notify ENCWG of issues noted above.
Has this been done?
It has now 😃
Apart from that it seems the PC should be complete by now (?)
Yes and no. The symbol review is identifying clipping issues with the symbol boxes in some cases (mostly when line styles wider than 0.32mm are used). This only affects the symbols, not the drawings. I assume these issues can be corrected as part of an overall symbol review. | Left edge | Bottom edge | Right edge |
---|---|---|---|
Decisions made at Portrayal subWG meeting on 18/10/23
The PsWG recognized that are clipping issues with some (a minority) of the symbol boxes, but these are probably not noticeable in ECDIS.
A decision was made to proceed with registration of the symbols and close this issue when done.
New symbols (to the S-101 portrayal - they are present in S-52) were added to label contours deeper than 99m; see PC issue 233
These symbols will need to be registered, but we may wish to hold off since they follow the current S-100 SVG schema. The S-100 SVG schema will likely be updated after the next S-100 WG meeting which will necessitate updating all of the symbols.