search

S-101-Portrayal-subWG / Working-Documents

16 stars 5 forks source link

Removal of IEC related symbols from S101 PC #155

Closed alvarosanuy closed 2 weeks ago

alvarosanuy commented 9 months ago 
          **Decisions made at Portrayal subWG meeting on 19/10/23**

CLOSE this Issue and create anew one to track the progress of the S101PT proposal to IEC.

Originally posted by @alvarosanuy in https://github.com/S-101-Portrayal-subWG/Working-Documents/issues/126#issuecomment-1776140669

alvarosanuy commented 9 months ago

Currently awaiting response from IEC on S101PT recommendation to centrally managing these symbols in the IHO GI Registry and making this repository the point of truth for all OEMs.

Irrespective of their decision on the S101PT recommendation, it was decided to remove all Mariners and Manufacturers symbols from S101 PC 2.0.0. The only exception being INDHLT and DNGHLT which are required for A&I.

Note that, based on decisions made at S101PT11, these symbols will be retained in PC 1.2.0.

alvarosanuy commented 7 months ago

Dear Chair of the IHO S-101PT,

IEC TC80/MT5 for maintenance of the IEC 62288 completed today a 2-day meeting. Please find attached liaison letter from IEC TC80/MT5 to IHO S-101PT as response to your liaison letter to the IEC.

Best regards

Hannu MT5-2309 Liaison letter from IEC TC80-MT5 to IHO S-101PT.zip

alvarosanuy commented 7 months ago

My understanding of this letter is that OEM's will source the 'Mariners' and 'Manufacturers' symbols from the S-52 PL (until a day when S-57 is sunset).

Also, IEC manifested interest in taking over all these symbols at the right time and via different mechanisms, maybe before S-57 sunset date.

HannuPeiponen commented 6 months ago

My reply to the question of Alvaro is: Yes, my understanding is that OEMs do not need these symbols “repeated” in S-101 PC as they can access these symbols from the S-52 PL until (and maybe even beyond) a day when S-57 is sunset.

alvarosanuy commented 3 months ago

Decisions made at Portrayal subWG meeting on 09/04/24

DavidGrant-NIWC commented 3 months ago
AreaFill Description
OVERSC01 Overscale part of a display containing data from more than one navigation purpose
LineStyle Description
CHCRDEL1 manual deletion
CHCRID01 manual update
ERBLNA01 Electronic Bearing Line
INDHLT02 mariners indication highlight
NONHODAT boundary of non-HO data
SCLBDY51 chart scale boundary
Symbol Description
BLKADJ01 symbol for checking brightness and contrast
CHCRDEL1 manually deleted or modified
CHCRID01 manuallly updated
CHINFO08 mariners information note
CHINFO09 mariners caution note
CHINFO10 manufacturers information note
CHINFO11 manufacturers caution note
CHKSYM01 symbol for checking symbol sizes
CURSRA01 ordinary cursor
CURSRB01 cursor with open centre
DNGHILIT transparent danger highlight for mariner's use
EBLVRM11 point of origin for an offset EBL or VRM
ERBLTIK1 range mark for an ERBL
INDHLT01 indication highlight for mariner's use
NORTHAR1 north arrow
REFPNT02 reference point, 'ghost cursor' (user interface)
SCALEB10 one mile scale bar
SCALEB11 10 mile latitude bar
TIDCUR01 predicted tidal stream or current direction
TIDCUR02 actual tidal stream or current direction
TIDCUR03 box for current strength
alvarosanuy commented 3 months ago

Should COLOUR ADINF be also considered for removal from S101PC ?

HannuPeiponen commented 3 months ago

AreaFill Description OVERSC01 Overscale part of a display containing data from more than one navigation purpose LineStyle Description CHCRDEL1 manual deletion CHCRID01 manual update ERBLNA01 Electronic Bearing Line INDHLT02 mariners indication highlight NONHODAT boundary of non-HO data SCLBDY51 chart scale boundary Symbol Description BLKADJ01 symbol for checking brightness and contrast CHCRDEL1 manually deleted or modified CHCRID01 manuallly updated CHINFO08 mariners information note CHINFO09 mariners caution note CHINFO10 manufacturers information note CHINFO11 manufacturers caution note CHKSYM01 symbol for checking symbol sizes CURSRA01 ordinary cursor CURSRB01 cursor with open centre DNGHILIT transparent danger highlight for mariner's use EBLVRM11 point of origin for an offset EBL or VRM ERBLTIK1 range mark for an ERBL INDHLT01 indication highlight for mariner's use NORTHAR1 north arrow REFPNT02 reference point, 'ghost cursor' (user interface) SCALEB10 one mile scale bar SCALEB11 10 mile latitude bar TIDCUR01 predicted tidal stream or current direction TIDCUR02 actual tidal stream or current direction TIDCUR03 box for current strength

I have noted that Jonathan Pritchard has created S-101 version of the "ECDIS Chart 1". Some of these sysmbols are used in "ECDIS Chart 1", therefore, such symbols should stay in PC of S-101 as the machine-readable S-100 compliant system needs them for rendering of the S-101 versions of the ECDIS Chart 1. Please ask Jonathan for details

HannuPeiponen commented 3 months ago

Should COLOUR ADINF be also considered for removal from S101PC ?

Colour "ADINF" is used by mariner symbol examples which are part of "ECDIS Chart 1". Jonathan Pritchard has created S-101 versions of the ECDIS Chart 1. Therefore, colour ADINF is needed in PC of S-101.

DavidGrant-NIWC commented 2 months ago

I have noted that Jonathan Pritchard has created S-101 version of the "ECDIS Chart 1". Some of these sysmbols are used in "ECDIS Chart 1", therefore, such symbols should stay in PC of S-101 as the machine-readable S-100 compliant system needs them for rendering of the S-101 versions of the ECDIS Chart 1. Please ask Jonathan for details

@kusala9 could you identify the items which will be used in Chart 1? Is there an expectation that the PC will be updated to support display/use of these items?

alvarosanuy commented 2 months ago

These are the portrayal elements mentioned in S-52 LUT and registered in the GI Registry as 'Mariners' Objects'. Mariners - S-52 PL & GI Registry.docx

The other ones listed by Dave seem to exist in the GI Registry and are referenced in the S-52 PL DAI file (I checked some entries, not all).

Couple of exceptions to the above - Functional requirements not linked to mariners' preferences or ECDIS GUI requirements (e.g. North arrow or Scale Bar). Until the day we have an IEC Catalogue, we need to support S-101 functional requirements in ECS that may not support S-52.

DavidGrant-NIWC commented 2 months ago

Recommend this is deferred to S-101 1.4.

kusala9 commented 2 months ago

I have noted that Jonathan Pritchard has created S-101 version of the "ECDIS Chart 1". Some of these sysmbols are used in "ECDIS Chart 1", therefore, such symbols should stay in PC of S-101 as the machine-readable S-100 compliant system needs them for rendering of the S-101 versions of the ECDIS Chart 1. Please ask Jonathan for details

@kusala9 could you identify the items which will be used in Chart 1? Is there an expectation that the PC will be updated to support display/use of these items?

Apologies. I only caught sight of this this week. Yes, some of the symb ps are required for the proposed S-164 Chart 1. I will compile the list and post to this thread. Tom has proposed a paper for the PT to retain these symbols (and colors / lifestyles) in the 101 PC.

DavidGrant-NIWC commented 2 months ago

Yes, some of the symbols are required for the proposed S-164 Chart 1

How are these going to be referenced? They aren't referenced by any existing rule and there aren't currently features in S-101 to associate with a new rule.

alvarosanuy commented 2 months ago

Deferring to PC 1.4.0 ...

TomRichardson6 commented 2 months ago

Further to Jonathan's point above I will reference this issue in the paper to S-101PT13 in June. This proposes a new feature with an attribute similar to the SYMINS attribute present in S-57 ENC. So this may require some symbols and possibly even colors to be included in the Portrayal Catalogue without specific rules which reference on the basis that drawing instructions in this attribute may reference them. Agree to defer to 1.4.0. But due to timeframes it may be necessary to start drafting the associated rule and preparing a listing of symbols ahead of PT13 assuming that the paper is endorsed by PT13.

DavidGrant-NIWC commented 2 months ago

Suggest creation of an issue in the DCEG/PS github to track implementation of the attribute and associated requirements. I assume that the attribute would contain one or more DEF (see S-100 Part 13) formatted drawing instructions:

"PointInstruction:LIGHTS82"
"Dash:0,3.6;LineStyle:_simple_,5.4,1.28,OUTLW;LineInstruction:_simple_"

Note that this creates a potential attack vector for code injection techniques. The PC rule should impose some simple restrictions on the supported functionality. The PS should also strongly encourage OEM's Lua implementations to be sandboxed and to ensure datasets are properly signed.

alvarosanuy commented 3 weeks ago

@DavidGrant-NIWC - Just wondering if you have enough guidance on this issue as to proceed with PC 1.4.0 implementation. If not, can you please detail what is needed from your point of view? The issue got a bit sidetracked by references to ECDIS Chart 1. My understanding is that you would remove all the portrayal elements you listed in your comment from 30APR less those that may be required for ECDIS Chart 1 implementation (linked to JP's paper to S101PT13 ?).

DavidGrant-NIWC commented 3 weeks ago

@kusala9 has an initial implementation he will provide; he was just waiting on the 1.4 FC (I added the draft 1.4 FC yesterday)

kusala9 commented 3 weeks ago

I will work with the 1.4 FC and list the symbols required. I have a simple LUA routine which accomplishes everything for Chart 1 (not sure we need anything more complex) and then I can list the symbols required. Rather than include the drawing instructions in their entirety it's easier to just provide either a symbol, colour token (for fill) or line style which seems to work fine. It is more restricted and so can be easily validated to avoid code injection issues. Is this to be done on a new issue, or documented on this one?

DavidGrant-NIWC commented 3 weeks ago

@alvarosanuy & @kusala9 confirm / update the list below. Items marked for retention are functional requirements or will be used in Chart 1.

Area Fills

AreaFill Retain Description
OVERSC01 Y Overscale part of a display containing data from more than one navigation purpose (jail bars)

Line Styles

LineStyle Retain Description
CHCRDEL1 Y manual deletion
CHCRID01 Y manual update
ERBLNA01 ? Electronic Bearing Line
INDHLT02 Y mariners indication highlight
NONHODAT Y boundary of non-HO data
SCLBDY51 Y chart scale boundary

Symbols

Symbol Retain Description
BLKADJ01 Y symbol for checking brightness and contrast
CHCRDEL1 Y manually deleted or modified
CHCRID01 Y manuallly updated
CHINFO08 Y mariners information note
CHINFO09 Y mariners caution note
CHINFO10 Y manufacturers information note
CHINFO11 Y manufacturers caution note
CHKSYM01 Y symbol for checking symbol sizes
CURSRA01 ? ordinary cursor
CURSRB01 ? cursor with open centre
DNGHILIT Y transparent danger highlight for mariner's use
EBLVRM11 ? point of origin for an offset EBL or VRM
ERBLTIK1 ? range mark for an ERBL
INDHLT01 Y indication highlight for mariner's use
NORTHAR1 Y north arrow
REFPNT02 ? reference point, 'ghost cursor' (user interface)
SCALEB10 Y one mile scale bar
SCALEB11 Y 10 mile latitude bar
TIDCUR01 ? predicted tidal stream or current direction
TIDCUR02 ? actual tidal stream or current direction
TIDCUR03 ? box for current strength
kusala9 commented 3 weeks ago

these are all the SY() lines in the current S-57 chart 1. From these I'll update the list above. I also need to go through the TX lines in the S-57 version and check nothing's been omitted.

kusala9 commented 3 weeks ago

and also check the other symbols are still included/used in the PC.

alvarosanuy commented 2 weeks ago

Decision at PsWG meeting on 10/7/2024

Retain all symbols until further notice. Close this issue.