Closed alvarosanuy closed 5 months ago
@alvarosanuy The UK will work to create the required symbols here and associated engineering drawings. Outputs will be posted here when ready.
@alvarosanuy please find attached new symbiology for review.
@alvarosanuy please find attached new symbiology for review.
@RichardCoyles - Thanks Richard. Would you be able to submit Engineering Drawings? I need them to finalise registration in the GI Registry. I have attached an example for your reference. @MikusRL may be able to assist as he had to create some in the past while using KHOA's Symbol Editor (my understanding is that this tool does not generate the ED file automatically as yet ...)
@HolgerBothien I found the drawings you produced for EWM https://github.com/S-101-Portrayal-subWG/Working-Documents/issues/117#issuecomment-1559313859
I will compare these dimensions with the EWM symbols I produced above, also based on BOYPIL01, BOYSPH01 and BOYSPR01.
Did you produce drawings for Safe Water Buoys also? I feel I may be stepping on your toes here?!
I see that EWM buoys Spherical, Pillar and Spar already exist in the registry with .svg and engineering drawings. The spherical buoy name should be amended from BOYSHP60 to BOYSPH60 to agree with the name of the .svg
SW buoys Pillar and Spar already exist in the registry with .svg and engineering drawings.
Buoy, spherical – safe water mark – paper chart does not exist in the registry. PSB engineering drawing and .svg for this BOYSPH50 engineering drawing.docx BOYSPH50
Thanks Richard for following up. Please refer to the document below (table at the end) with my comments. Apart from new versions for BOYSPH50 and BOYSPH60, we need 2 other new symbols (EWMB Spar & Pillar) as per the images in my first comment in this GitHub issue.
Alvaro - graphical comments.docx
The key requirement for all these 4 new symbols is to have the line between colours at an angle (015 degrees approx). This is to address Guttorm's concerns as this seems to be the rule for all floating navaids having vertical stripes.
I will make the changes in the .docx above.
symbols with slanting colours: BOYSPH50 BOYSPH60 BOYSPR60 BOYPIL60
and associated engineering drawing with comments: BOYSPH50 engineering drawing.docx BOYSPH60 engineering drawing.docx BOYSPR60 engineering drawing.docx BOYPIL60 engineering drawing.docx UKHO.-.graphical.comments.docx
@RichardCoyles - Thank you very much Richard. I noted a few comments against KHOA's symbol editor performance and some questions for @HolgerBothien. I propose we document known shortfalls in KHOA's tool at the upcoming meeting and use that to create an Issue in the 'Infrastructure' GitHub space to get them resolved in a new version of the symbol editor.
@HolgerBothien - Would you mind addressing Richard's comments included in the uploaded Engineering Drawing documents?
Decisions made at Portrayal subWG meeting on 09/04/24
Approve new versions of the symbols BOYSHP50, BOYSHP60
Approve new symbols BOYSPR60 & BOYPIL60
[ ] NIWC to update mapping Rules for 'Paper Chart' symbology as follows:
SafeWaterBuoy - buoyShape=3 colour=1,3 BOYSHP50 - Current mapping is correct in PC 1.2.3. Update symbol version only.
SafeWaterBuoy - buoyShape=3 colour=3,1 BOYSHP50 - Current mapping is correct in PC 1.2.3. Update symbol version only.
EmergencyWreckMarkingBuouy - buoyShape=3 BOYSPH60 - Current mapping is correct in PC 1.2.3. Update symbol version only.
EmergencyWreckMarkingBuouy - buoyShape=5 BOYSPR60 - New Mapping
EmergencyWreckMarkingBuouy - buoyShape=4 BOYPIL60 - New Mapping
[ ] Alvaro to update the GI Registry
[ ] NIWC to upload screenshots if Test Data is available
EWMB mappings look correct but new files need at least iho:S100SVG namespaces to be updated. I will take care of this and post updates here.
Dataset: GITHUB\S-101-Test-Datasets\S-101_1.2\000\101AA00DS0020.000
BOYSPH50:
BOYSPR60: This doesn't look good
BOYPIL60:
BOYSHP60:
Corrected metadata in SVG files
Tend to agree with @mikan66 - Below are the original images provided bu Guttorm and the SVG's we plan to register. @RichardCoyles - Is there anything you can do to improve the Spar symbol? Maybe make it a bit wider or make the line thinner (although I imagine line thickness matches other symbols in the GI Registry).
@alvarosanuy, @RichardCoyles I also notice that the descriptions have changed on these and some don't make sense. For example:
I can clean these up to match PC 1.2.3 if you like. Please advise.
Implemented in PC 1.3.0
Pending actions taken form https://github.com/S-101-Portrayal-subWG/Working-Documents/issues/117:
[ ] Create a new version of the Safe Water 'Paper Chart' symbol BOYSHP50 (to show slanted color bands)
[ ] Create a new version of the EWMB 'Paper Chart' symbol BOYSHP60 (to show slanted color bands)
[ ] Create new EWMB 'Paper Chart' symbol for 'Pilar' & 'Spar' buoy shapes
[ ] Update Rule mappings to new symbols when available.