S-101-Portrayal-subWG / Working-Documents

17 stars 5 forks source link

EWMB incorrect in dusk and night palettes #167

Open DavidGrant-NIWC opened 5 months ago

DavidGrant-NIWC commented 5 months ago

For consistency with the other color filled symbols the EWMB should use color token OUTLW to stroke the outline. This will keep the outline black in all color palettes.

Affected symbols: BOYSPH50, BOYPIL60, BOYSPH60, BOYSPR60

Dusk Night
image image
DavidGrant-NIWC commented 5 months ago
The affected symbols have been updated in the PC to address this issue. Close this issue if the pics below look correct: Dusk Night
image image
alvarosanuy commented 5 months ago

To be honest I think I prefer to visualise the outline and the position circles of the symbols. In short, I think the symbols you changed should be the standard and all other color filled symbols should be amended to match. We could track this activity for '2.0.0 or later'.

To the PsWG team - What's your view on this?

Visible outline examples:

image image

No visible outline examples:

image image

DavidGrant-NIWC commented 5 months ago

I agree with you and initially was going to change the symbols as you suggest. However, I noticed that all the S-52 color filled symbols use "OUTLW" to outline the color. "OUTLW" stays black in all palettes.

The new color filled symbols are just maintaining consistency with the existing. Changing this would require changing all of the color filled buoys, beacons, and lights. It would also be inconsistent with S-52.

image

alvarosanuy commented 5 months ago

Noted. Your changes to PC 1.3.0 are ok but, I'll leave this issue open to hear some other points of view or, at least, for discussions at the next PsWG meeting.

For 'Simplified' colored symbols, not 'seeing' the outline is not that bad as they do not have the baseline with the position circle as 'Paper Chart' symbols do. Now that we introduced colored versions of the "Paper Chart' symbols the use of OUTLW in Dusk and Night modes is not ideal.

alvarosanuy commented 2 months ago

Decision at PsWG meeting on 10/7/2024

Not for PC 2.0.