S-101-Portrayal-subWG / Working-Documents

16 stars 5 forks source link

Incorrect drawing of some Complex line styles - Part 3 #91

Closed alvarosanuy closed 1 year ago

alvarosanuy commented 2 years ago

Dedicated Github issue to discuss topic presented by dKart (@IngaFjellanger) in the paper below (bullet point 9):

Comments to Portrayal Catalogue_last version.docx

Extract from paper:

  1. Symbols EMLOWAC(01/31).svg use stroke-width equal to 0.64. Symbols view unreadable since their height is equal to 0.79 and width = 1.3. Their borders join together. Besides it does not comply with S-52. Suggest stroke-width equal to 0.3

image

IngaFjellanger commented 2 years ago

ThickLOWACC_comment#9.zip Here is a document and some svg files

TDYCARHugh commented 2 years ago

I can see in the original conversion that the linewidth was 1 pixel (0.3) and afterwards those symbols were modified manually to have a 2 pixel (0.64) width.

I vaguely recall that there was a change being made around that time to make all conspicuous symbols use a 0.6 line width instead of 0.3.

Perhaps it was something done as an intended improvement in S-101 portrayal that was not included in S-52? I have not found documentation about it.

DavidGrant-NIWC commented 1 year ago

Will revert to S-52 presentation in PC 1.1.0

alvarosanuy commented 1 year ago

Portrayal subWG meeting - 11th January 2023

  1. Decided to revert line thickness to 0.3mm to match S-52. @DavidGrant-NIWC to update EMLOWAC01; 11; 21; 31; 41 and upload new versions to this space so Alvaro can commence registration in the IHO GI Registry.

  2. For PC 1.1.0.

DavidGrant-NIWC commented 1 year ago

EMLOWACnn.zip

DavidGrant-NIWC commented 1 year ago

Incorporated in PC 1.1.0: https://github.com/iho-ohi/S-101_Portrayal-Catalogue/issues/139

alvarosanuy commented 1 year ago

New symbols have been updated to the GI Registry (new versions of existing symbols).