S-101-Portrayal-subWG / Working-Documents

16 stars 5 forks source link

Depth contour values #97

Closed Christian-Shom closed 7 months ago

Christian-Shom commented 2 years ago

From ENCWG "Display Sub WG" Too many values shown on the ECDIS. image Although this seems to be an ECDIS issue, interesting to look if some guidance or portrayal rule can be added somewhere.

DavidGrant-NIWC commented 2 years ago

The current S-101 portrayal places a label half-way along the contour.

This is not ideal (because the label position may not be on the screen, or the curve may be long and winding so that the label is hard to associate with a particular segment), but the Part 9 model limits what is possible with regard to text placement associated with curves. Ideally, we would extend the model to at minimum support line symbol placement based on visibleParts as is provided for area placement.

Another limiting factor is that the portrayal doesn't know the length of the visible portion(s) of the curve, so it can't dynamically add/remove labels based on the length.

image

See also S-52 portrayal bulletin PB6:

​​​​​​​PB6 - S-52-CPB-No 8: Equal placement of depth contour labels (CSMWG18 Action 16) Depth contour lines are often coded in segments of equal status with varying run lengths. Short contour segments are sometimes not optimal for the presentation of contour labels if the generic rules of DPCNT03 are too strictly applied. Therefore, the interpretation of DEPCNT03 rules to display depth contour labels should be interpreted in a way, that it results in an equal spaced placement of the labels with a distance which is independent from the fraction of the contour into segments and fits well to the selected display scale.​​​​​​​

and an implementation note from S-100WG3-8.5 (as noted above, this has been changed in the current portrayal): image image

alvarosanuy commented 1 year ago

The problem in the screenshot is that, either due to lack of good S-52 guidance or due to bad implementation by OEMs, labels where added on each geometric Edge and not on the overarching DEPCNT feature. If this has now been solved in S-101 (by directing adding a label at the center of the feature) then we should now focus on making sure that something is displayed when the 'center' of the depth contour is not on the ECDIS display. As suggested by Dave, this can be done by using the visibleParts concept (similarly to Surfaces) or maybe by instructing the display of labels every 120 mm (?) on the screen.

DavidGrant-NIWC commented 1 year ago

As suggested by Dave, this can be done by using the visibleParts concept [...]

Will require changes to S-100 Part 9 / 9a. visibleParts is not currently an option for lines. We'll generate a proposal for the upcoming WG.

DavidGrant-NIWC commented 1 year ago

or maybe by instructing the display of labels every 120 mm (?) on the screen.

ShoreECDIS 2022-09-28T221707Z

1:12k 1:4k
ShoreECDIS 2022-09-28T213719Z ShoreECDIS 2022-09-28T213957Z
1:45k 1:12k
ShoreECDIS 2022-09-28T214522Z ShoreECDIS 2022-09-28T214656Z
ShoreECDIS 2022-09-28T221226Z ShoreECDIS 2022-09-28T221236Z
alvarosanuy commented 1 year ago

@DavidGrant-NIWC - Thanks for prototyping the idea. I think it looks promising. My only concern is about leaving some small isolated shoals/deeps without a contour value. I understand that the reason is that the contour's total length is =< 120mm on the screen but, is there anyway to 'force' the display of a CV per contour when their total length =< 120 mm? Encoding at least one CV per depth contour is a recognised paper chart (S-4) practice. I'm sure there will be valid points against and in favour of replicating this in ECDIS (considering that mariners have other tools available such us pick report and alarms) but I think it's important to keep this in mind when discussing this topic and coming up with decisions.

alvarosanuy commented 1 year ago

Portrayal subWG meeting - 12th January 2023

  1. @DavidGrant-NIWC confirmed that the paper was presented at S100WG7 and that although the CRS proposal was approved, the use of the 'Visible Parts' concept for Curves was not.

  2. The subWG decided to go ahead with the implementation tested above by NIWC (equidistant labels every 120mm with the first label starting 20-30mm from the beginning of the Curve). NIWC proposed to delay implementation to PC 1.2.0 to wait for the official publication of the CRS change in the corresponding S100 document. This was supported by the subWG.

DavidGrant-NIWC commented 1 year ago

Use of 'Visible Parts' concept is approved for S-100 edition 5.1: image

alvarosanuy commented 1 year ago

Decisions made at Portrayal subWG meeting on 11/5/23

alvarosanuy commented 10 months ago

Decisions made at Portrayal subWG meeting on 17/10/23

DavidGrant-NIWC commented 7 months ago

Implemented via PC 228

Sample using a test dataset:

1:22k (centered on each visible portion) 1:45k (centered on single visible portion)
image image

Mostly off screen: image