S-101-Portrayal-subWG / Working-Documents

16 stars 5 forks source link

Underwater rock hides a Land area. #99

Closed Christian-Shom closed 6 months ago

Christian-Shom commented 2 years ago

From ENCWG "Display Sub WG" Underwater rock symbol covers (hides) point Land area (which is a more dangerous feature). image This has not been ckecked in S-101. If confirmed, could this be improved playing with the Display Priority: a feature should never mask a more dangerous one? In this specific case, there may be a compilation issue: is it necessary to show the Underwater rock so close to the island? But there may be other situations that need to be improved. Probably needs further investigations.

alvarosanuy commented 1 year ago

Portrayal subWG meeting - 12th January 2023

  1. It seems to be a problem with the priority allocated to LandArea features of type Point.

  2. The subWG decided to experiment with altering the DP on a test data set. It is important to confirm that unwanted results on other features are not accidentally triggered by this change.

  3. Norway will provide the S-101 ENC test data set and will perform the assessment and report findings at the next subWG meeting. NIWC is to assist Norway by providing a PC version that has a higher priority allocated to LandArea point features.

TomRichardson6 commented 1 year ago

Test Dataset 13 Edtn 5 has been updated to try and reflect this scenario

https://github.com/iho-ohi/S-101-Test-Datasets/tree/main/dev/cells/101AA00DS0013

DavidGrant-NIWC commented 1 year ago

TL;DR

To ensure LandArea is always on top of any UnderwaterAwashRock (and other potential isolated dangers) would require a drawing priority greater than 24 (8 in S-52), or changing the priority of many features. Unfortunately, text and the danger highlight also share priority 24; moving LandArea to 25 would obscure text, and cause the feature to obscure the danger highlight.


Details

Selected Safety Contour Selected Safety Depth UnderwaterAwashRock LandArea Result
30 30 Priority=24 Priority=12 image
0.5 30 Priority=12 Priority=12 image
0.5 0.5 Priority=12 Priority=12 image

Note: Even with the safety contour set to 0 the safety checks will detect the LandArea (provided the route intersects the point): image image

TDYCARHugh commented 1 year ago

This will also be an issue in S-52. I don't think this can be solved by adjusting priorities. With a small land area surface the coastline draws at a higher priority so it can still be seen. So as stated above the issue is with a point land area. The symbol covering other data is the DANGER01 symbol which is filling the oval with a solid DEPVS colour and masking anything underneath. Keep in mind that DANGER01 is only used when the surrounding area is shallow water. Maybe we could try using a transparent fill for DANGER01. With a 50% transparency the land area point can still be seen.

The first image below is using the current DANGER01 symbol. The land area surface (upper left) coastline can still be seen. The Land Area point (upper right) is hidden. In the second image DANGER01 is using a 50% transparency for the fill. (style="fill-opacity:0.5;")

DANGER01_Solid DANGER01_50
DavidGrant-NIWC commented 1 year ago

With a 50% transparency the land area point can still be seen.

That could work, but bear in mind that as additional danger objects are stacked the fill would become progressively more opaque.

alvarosanuy commented 1 year ago

That could work, but bear in mind that as additional danger objects are stacked the fill would become progressively more opaque.

I hope SCAMIN kicks in and symbology is cleared up as the ENC is zoomed out .... I'm of the opinion that, if cartographers attribute SCAMIN (as a chart generalisation tool) based on what they see at each comp. scale, we wouldn't be talking about these overlaps being a problem .....

Having said this, I'm happy to pursue the recommendation presented by Hugh (50% transparency).

alvarosanuy commented 1 year ago

Decisions made at Portrayal subWG meeting on 11/5/23

alvarosanuy commented 10 months ago

Paper submitted to NCWG9 (Nov 2023). Will leave this issue open until we get feedback from NCWG Chair.

MatthewCraggs commented 6 months ago

Below are the comments from NCWG9.

Underwater rocks, hides land area point features, meaning the more dangerous feature is being overridden by a less dangerous feature, how to proceed?

Important to note that no unanticipated unwanted changes must be allowed to occur as a result. Changing the display priority on test dataset has been considered and tested, additional new complications were created, adjusting the priority is not the solution. Options, SCAMIN, transparency, extend the land over the rock, capture a danger line around the island, capture the island in the true position and offset the rock,

Outcome: NCWG recommends improved encoding guidance rather than offsetting features from their true position is the better solution.

alvarosanuy commented 6 months ago

NCWG decided not to amend symbology or portrayal rules.