search

S-C-A-N / SCANsat

Real Scanning, Real Science, at Warp Speed!
217 stars 97 forks source link

Crash when using RPM in 1.8 #359

Open JonnyOThan opened 4 years ago

JonnyOThan commented 4 years ago

I was using my new build of RPM for ksp 1.8 (https://github.com/JonnyOThan/RasterPropMonitor/releases/tag/v0.31.0) and SCANSat and hit a crash. I'll probably eventually get around to looking into this myself, but just wanted to log it here for tracking.

I had a target active, and the regular RPM orbit view, then clicked over to the map page.

[LOG 22:29:49.282] JSISCANsatRPM: Active on page 10
[EXC 22:29:49.576] NullReferenceException: Object reference not set to an instance of an object
    SCANsat.SCAN_UI.JSISCANsatRPM.DrawTrail (System.Collections.Generic.IList`1[T] points, UnityEngine.Color32 lineColor, UnityEngine.Vector2d endPoint, System.Boolean hasEndpoint) (at <532e0c7735694646a2dba646ef08b593>:0)
    SCANsat.SCAN_UI.JSISCANsatRPM.DrawOrbit (Vessel thatVessel, Orbit thatOrbit, System.Double startMoment, UnityEngine.Color32 thatColor) (at <532e0c7735694646a2dba646ef08b593>:0)
    SCANsat.SCAN_UI.JSISCANsatRPM.MapRenderer (UnityEngine.RenderTexture screen, System.Single cameraAspect) (at <532e0c7735694646a2dba646ef08b593>:0)
    JSI.MonitorPage.RenderBackground (UnityEngine.RenderTexture screen) (at <8e6d86737d634e76a3a37f1485ceb702>:0)
    JSI.RasterPropMonitor.RenderScreen () (at <8e6d86737d634e76a3a37f1485ceb702>:0)
    JSI.RasterPropMonitor.OnUpdate () (at <8e6d86737d634e76a3a37f1485ceb702>:0)
    InternalProp.OnUpdate () (at <9d71e4043e394d78a6cf9193ad011698>:0)
    InternalModel.OnUpdate () (at <9d71e4043e394d78a6cf9193ad011698>:0)
    Part.InternalOnUpdate () (at <9d71e4043e394d78a6cf9193ad011698>:0)
    Part.Update () (at <9d71e4043e394d78a6cf9193ad011698>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)

KSP.log

EDIT: by inspection, it seems this might be fixed by PR #354 - if that results in trailMaterial being null inside DrawTrail.