search

S-K-Y-Light / pe

0 stars 0 forks source link

Unable to Schedule Lesson due to existing Clash with MakeUp Lesson #2

Open S-K-Y-Light opened 4 days ago

S-K-Y-Light commented 4 days ago

According to the UG, only regular lessons should be weekly occuring, which appears in the calendar on the side. Makeup lessons should only occur once on the specified days, and do not appear in the calendar.

image.png

image.png

As such, I expect to be able to schedule regular weekly lessons. However, I'm unable to schedule a lesson due to an existing clash with a ONE-TIME Makeup Lesson on the 25-10-24.

Command: schedule 8 d/Friday st/11:00 et/12:00 Expected: Student 8 has Lesson Scheduled on Friday 11:00 to 17:00 Result: Command Result Display Notifies me that there is an existing clash on 25-10-2024

image.png

nus-pe-bot commented 21 hours ago

Team's Response

Firstly, make up lessons do show up on the calendar view. The view is set to Nov 11 to Nov 17, which is not the week containing the makeup lesson you mentioned.

Secondly, it is expected behaviour, as the user should be warned if they have a makeup lesson on a date that they are trying to schedule a new weekly lesson on. For e.g, student A has makeup lesson next Thursday. If I am scheduling a weekly lesson with student B on Thursday at the same time, then I should be warned that it clashes.

image.png

Thirdly, if your issue is with makeup lessons in the past preventing you from scheduling weekly lessons, then this is included in our planned enhancements.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Hi Team, I think there's been a misunderstanding on the issue I'm raising here. Allow me to address each of your points raised.

Firstly, I'm aware that the calendar does not reflect clashing lesson, as I've did not set the GUI to view the appropriate calendar week. However, this is irrelevant to the Feature Flaw I'm raising.

Secondly, I understand that this is the expected behavior, which is the reason why I reported the bug as a Feature Flaw, and not Functionality Bug. I'll elaborate more on the Feature Flaw below.

Thirdly, My Issue isn't about whether the Lesson is in the past or future. The Date I've picked (25-Oct 2024) is just a MakeUp Lesson that exists in Key Contacts. The Feature Flaw I'm discussing about applies to both past & future lessons.

Now for the Feature Flaw. I find that the whole idea of Having Regular Lessons (being a Weekly Affair) & MakeUp Lessons Being One Time causes KeyContacts to be very restrictive. To best explain my point, I'll provide an analogy. I'm a Teacher with 3 Students. Let's say that all 3 students have One-Time MakeUp Lessons Scheduled in the next week. Student A: Next Monday 3pm - 4pm Student B: Next Wednesday 1pm - 2pm Student C: Next Friday 6pm - 8pm Then comes in a new Student D who wishes to have regular weekly lessons on Friday 5pm - 7pm. Student D's Lessons will begin in the following Friday, so there shouldn't be a clash with Student C. However, I'm unable to add this 4th Student's Lessons to KeyContacts due to an existing clash with Student C's One-Time MakeUp Lesson. All because of One Single MakeUp Lesson, I'm unable to appropriately add in Student D for regular lessons and must instead wait to delete the One-Time MakeUp Lesson from Student C once it has passed. I find that having such a system makes KeyContacts extremely restrictive, and I'm unable to properly add all my students lessons into KeyContacts when I wish to immediately. Instead, I must make a reminder to myself to add in Student D's Lessons. This greatly reduces the value I gain from KeyContacts, especially for Piano Teachers where a lot of early planning (possibly a month long) is required to schedule Lessons with Students.

Hence, the issue I'm raising is that of a Feature Flaw causing KeyContacts to be too restrictive. I hope this provides some clarification.