S-Man42 / GCWizard

GC Wizard
Other
43 stars 10 forks source link

AMSCo Cipher error message #1699

Closed Linsty closed 2 weeks ago

Linsty commented 2 weeks ago

Hi

The behavior of the AMSCO Cipher is a bit confusing. This is related to the order of the columns and an error message.

Example 1: I enter the key 123. I receive no error message and the output follows the order: The columns are in order 123. The function executes as follows: 1: Letters from column 1 2: Letters from column 2 3: Letters from column 3. The output is as expected. afbeelding

Example 2: I enter the key 321. I receive an error message "Wrong key!" but the function executes as expected: The columns are in order 321. The function executes as follows: 1: Letters from column 1 2: Letters from column 2 3: Letters from column 3. afbeelding

The error message remains visible as long as I continue to use the function. So, if I correct the key to 123, the error message persists.

The error message stays on the screen until I open a different function or exit GC Wizard. afbeelding

The manual specifically mentions: "The key may only consist of consecutive digits from 1 to 9, with each digit occurring only once."

I interpret this to mean that the error message is technically correct. If that's the case. Isn't it easier to implement a selection menu (like Key A in Affine Cipher) where a user specifies the number of columns and GC Wizard generates the column names automatically? (This avoids an error handling like double numbers and zero's too)

If the order of the digits can be changed, then this error message is unnecessary.

I tested in Android and in the web version.

If something isn't clear, feel free to contact.

Kind regards,

Marcia

Mike-3 commented 2 weeks ago

That was an error with the message, it couldn't be displayed correctly in a certain state. We had to change it a while ago, which is probably how the problem came about. The problem should be fixed in the next version.

Linsty commented 2 weeks ago

Glad it was an easy fix 😊

From: Mike-3 @.> Sent: Friday, June 21, 2024 6:48 PM To: S-Man42/GCWizard @.> Cc: Marcia @.>; Author @.> Subject: Re: [S-Man42/GCWizard] AMSCo Cipher error message (Issue #1699)

That was an error with the message, it couldn't be displayed correctly in a certain state. We had to change it a while ago, which is probably how the problem came about. The problem should be fixed in the next version.

— Reply to this email directly, view it on GitHub https://github.com/S-Man42/GCWizard/issues/1699#issuecomment-2183096622 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AMLAKQ5LHZBPC5V4Q3MY3ZTZIRKM5AVCNFSM6AAAAABJVK24IOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBTGA4TMNRSGI . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AMLAKQ3EZE6BU5LUMLEWAO3ZIRKM5A5CNFSM6AAAAABJVK24IOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUCD5US4.gif Message ID: @. @.> >