search

S-aiueo32 / contextual_loss_pytorch

Contextual Loss (CX) and Contextual Bilateral Loss (CoBi).
MIT License
172 stars 45 forks source link

[Bug Report] Parameters are delivered incorrectly. #5

Open Kitsunetic opened 4 years ago

Kitsunetic commented 4 years ago

I found some bugs and fixed it. Please check my pull request.

  1. Parameter loss_type is being ignored in both ContextualLoss and ContextualBilateralLoss.
  2. Parameter band_width in ContextualBilateralLoss is treated as weight_sp.
  3. Parameter loss_type is better to compared in lower case.
  4. Default value of parameter band_width in ContextualBilateralLoss is 0.5 but F.contextual_bilateral_loss have default value of 1.0.

Thank you.