search

S4-NetQuest / react-scorm-provider

Components to easily enable SCORM API communication in React projects.
MIT License
61 stars 19 forks source link

Added support to the location field #13

Open diegoprestes opened 4 years ago

diegoprestes commented 4 years ago

Added field location that handles: SCORM 1.2: cmi.core.lesson_location or SCORM 2004: cmi.location

diegoprestes commented 4 years ago

I was doing some adjustments for objectives as well, and committed it, but I didn't know it would be included to this PR. Basically it adds also a easy way to use the objectives without having to do the set for each value.

JayV30 commented 4 years ago

I was doing some adjustments for objectives as well, and committed it, but I didn't know it would be included to this PR. Basically it adds also a easy way to use the objectives without having to do the set for each value.

Thanks for all of this. I know there are some major issues and missing functionality in this project. I recently ran across major problems with completion status reporting to SCORM 2004. This is in part due to the reliance on the Pipwerks SCORM API wrapper and the ways it handles certain methods. Initially I built this as a quick and easy way to work with 1.2 and largely ignored 2004. This was a mistake and there needs to be some major work done on refactoring this entire project and remove the Pipwerks wrapper.

I mention this because I am hesitant now to continue adding in more complex and potentially opinionated functionality considering the entire project needs a refactor. I'll try to find some time this coming week to look at the objectives code you added and we can decide together whether to include it in a release now, or wait until the next major version.

Again, thanks for the contributions. I really appreciate them - I haven't had time recently to contribute to this and I'm glad to see someone is using it! (despite the issues it has)

diegoprestes commented 4 years ago

I recently started using React and now I had a project with SCORM that I had a chance to start using it together, this lib was the first result I got, but I'll need these location and objectives features to work with that. Instead of creating a fork and adding a new npm package for that I decided to create the PR, so maybe we could include it on the original repository. In case you think it doesn't make sense to include it now before the refactor, I can continue using it from the fork.