1.3.4 Bug Patch - Githubissues

S4WA / SoundCloud-Player

For all of the soundcloud heavy users.

https://akiba.cloud/soundcloud-player/

GNU General Public License v3.0

22 stars 6 forks source link

1.3.4 Bug Patch #20

Closed S4WA closed 2 years ago

S4WA commented 2 years ago

Fixing its behavior of openSCTab(), Upload fixed version on Chrome Webstore.

S4WA commented 2 years ago

[x] Stop publishing the draft on the WebStore.
[x] Replace the draft from 6f166284ee23b3010d89f8c25432e668e0f2dfb4 to 0fad580ad30f88b30f9730d802273aed2353bccd as version 1.3.4, on Releases (Github) too.

S4WA commented 2 years ago

There were a missing if statement on the contents.js.

It was including an unnecessary query. Usually in_system_playlist is used to be for a recommended private playlist from SoundCloud for each user. If another person who opens an url that have an unnecessary query, the web shows an error that says as a private playlist. In short, It doesn't really matter, however, I had to put an idiot-proof.

in_system_playlist is something like this:

S4WA commented 2 years ago

No need to update & send all of data in every half a second.

S4WA commented 2 years ago

Yeah and my dumbass did the same mistake.

[x] swap files from 0fad580ad30f88b30f9730d802273aed2353bccd to 216b71ea855bf73ea93750e800e33c16b6202bed .

S4WA commented 2 years ago

MAYBE IT'S BETTER TO OVERHAUL AGAIN? https://stackoverflow.com/questions/27383224/chrome-extension-long-lived-message-connection-how-to-use-callback-functions