search

S7NetPlus / s7netplus

S7.NET+ -- A .NET library to connect to Siemens Step7 devices
MIT License
1.3k stars 580 forks source link

Add overloads taking (ReadOnly)Memory<byte>/Span<byte> arguments #481

Closed ArgusMagnus closed 1 year ago

ArgusMagnus commented 1 year ago

It would be great to have overloads of the ReadBytes/WriteBytes methods and their async counterparts which take Span<byte> and the like as arguments. This would enable us to read/write array slices.

If this is something you would accept, I may be able to provide a pull request for this.

mycroes commented 1 year ago

I'm definitely open to accepting those. Feel free to submit a PR when you're up to it.

ArgusMagnus commented 1 year ago

I created the pull request #482

mycroes commented 1 year ago

Fixed by #482, released as part of v0.17.0.