search

S7NetPlus / s7netplus

S7.NET+ -- A .NET library to connect to Siemens Step7 devices
MIT License
1.34k stars 593 forks source link

Add support for reading/writing the legacy DATE (IEC date) datatype #506

Closed bonk-dev closed 1 year ago

bonk-dev commented 1 year ago

Solves #505

I did not bother with adding this type to struct serialization, because the DateTime type itself is not supported either. I might create a separate PR and add both the DateTime and IEC date to struct later on.

mycroes commented 1 year ago

Hi @bonk-dev, sorry for my late response. Thankfully @gfoidl did a review quickly and I agree with his comments. Only thing that would've been nice is test-cases for the new conversion, but I'll accept this as-is. Thanks a lot for your contribution!