SAA-SDT / EAD3

https://www.loc.gov/ead/index.html
Creative Commons Zero v1.0 Universal
84 stars 25 forks source link

`@char` and `@charoff` should be in `<tgroup>`? #444

Closed ruthtillman closed 9 years ago

ruthtillman commented 10 years ago

Now that @align has the possible value of "char" again, should @char and @charoff be added to <tgroup>, since it has @align? Otherwise one might set the value to "char" but not be able to add the data for it. Or should it just be left as is because it's kind of meaningless and should be set in <colspec> anyway?

Right now, <colspec> and <entry> are the only places where those two attributes can be used.

Just throwing it out as I update EADiva to match the revisions to table.

rockivist commented 10 years ago

@ruthtillman Good catch. The EAD 2002 tag library definition for <tgroup> (http://www.loc.gov/ead/tglib/elements/tgroup.html) even includes instructions to use @char and @charoff even though those attributes aren't permitted in in the schema.

@dpitti Is this a mistake in the EAD 2002 schema? If so, we can add @char and @charoffto <tgroup> in EAD3. If they were omitted intentionally, we'll leave it alone.

rockivist commented 10 years ago

@tcatapano I heard from @dpitti via email. He thinks this was an accidental omission in EAD 2002. I think we should add @char and @charoff to <tgroup> for the sake of consistency. I checked and tgroup is the only element where @align is permitted but @char and @charoff are not, so that should be the only change necessary. I'll leave it to you to make the change so I don't interfere with your schema edits. When you are done keep the issue open until @kshepher updates the tag library.

tcatapano commented 10 years ago

Implemented. Closed.

rockivist commented 9 years ago

@tcatapano This didn't make it into ead_revised_defs.rng. Can you re-add?

rockivist commented 9 years ago

@tcatapano Actually - wait on this. Let's discuss on Friday. Looking at this again I'm changing my mind and I think it might be better left as it was in EAD 2002.

tcatapano commented 9 years ago

Discussed and decided to not include in EAD3.