search

SAA-SDT / EAD3

https://www.loc.gov/ead/index.html
Creative Commons Zero v1.0 Universal
84 stars 25 forks source link

Values for @mark and @numeration #478

Closed kerstarno-zz closed 9 years ago

kerstarno-zz commented 9 years ago

It seems contradictory that we have the values "upperalpha", "loweralpha", "upperroman", "lowerroman" for @numeration with ordered lists as well as for @mark with unordered ones. Might be an idea to separate these.

Also, as this is supposed to be aligned with CSS, the values should be used with a hyphen.

MicheleCombs commented 9 years ago

Agree. Unordered lists by definition don’t have letters or numbers, otherwise they become ordered lists.

From: Kerstin Arnold [mailto:notifications@github.com] Sent: Thursday, July 09, 2015 3:53 PM To: SAA-SDT/EAD-Revision Subject: [EAD-Revision] Values for @mark and @numeration (#478)

It seems contradictory that we have the values "upperalpha", "loweralpha", "upperroman", "lowerroman" for @numeration with ordered lists as well as for @markhttps://github.com/mark with unordered ones. Might be an idea to separate these.

Also, as this is supposed to be aligned with CSS, the values should be used with a hyphen.

— Reply to this email directly or view it on GitHubhttps://github.com/SAA-SDT/EAD-Revision/issues/478.

rockivist commented 9 years ago

@kerstarno Thanks for spotting this.

@tcatapano Go ahead and implement. I have updated the tag library to reflect the following:

@mark values: disc, circle, square, none, inherit

@numeration values: decimal, decimal-leading-zero, lower-roman, upper-roman, lower-greek, lower-latin, upper-latin, armenian, georgian, lower-alpha, upper-alpha, inherit

tcatapano commented 9 years ago

implemented.