search

SAA-SDT / EAD3

https://www.loc.gov/ead/index.html
Creative Commons Zero v1.0 Universal
80 stars 25 forks source link

Create schematron test to restrict quantity values to numbers #484

Closed rockivist closed 4 years ago

rockivist commented 9 years ago

As suggested by @tcatapano. Data type of integer or decimal.

noahgh221 commented 5 years ago

@fordmadox , @rockivist , Do either of you know if this issue was intentionally dropped? Was there a decision not to restrict quantity values to numbers? Just trying to close out some old, old issues.

rockivist commented 5 years ago

I think this just got lost in the shuffle as we were tying up loose ends with the Schematron. Is there a chance Terry did this and it's in a dev branch somewhere? If not, I think it's safe to note that it would still be a good idea but then close the issue. If it comes up again later it could be revisited then.

tcatapano commented 5 years ago

I don't recall this. I'll check to refresh my memory and get back. Why not keep it open for now?

We may have rejected this as being too strict a rule. There's certainly many cases in which quantity values are not integers or decimals.

kerstarno commented 4 years ago

Issue review in preparation to upcoming EAD subteam call on 23 September:

@tcatapano - any chance you found anything pointing to this intially having been dropped with good reason?

@karinbredenberg and @fordmadox - provided we kept this open, might it rather be an issue for the Schema subteam?

karinbredenberg commented 4 years ago

@kerstarno if the data type is integer or decimal it should not be possible to write something else. So whats needed is to find if there are other elements/attributes that are seen as quantity vales with not data type integer or decimal and when that list is made it can be decided if it needs to be a rule for them. (Or they should perhaps have the data type being correct which means its part of a major revision.)

kerstarno commented 4 years ago

EAD team discussed this issue once more during their meeting on 3 December 2019.

We don't see this to be an urgent community requirement, especially as it has not been requested or followed up for quite some time, and also are not 100% sure as to whether this might be too strict.

We would hence close this issue for the time being, but will be open to re-evaluate if community requests should be received in future.