search

SAA-SDT / EAD3

https://www.loc.gov/ead/index.html
Creative Commons Zero v1.0 Universal
80 stars 25 forks source link

Change data type for @containerid from NMTOKEN to string so it can accept special characters #512

Closed noahgh221 closed 6 years ago

noahgh221 commented 6 years ago

Barcode values may contain special characters (e.g. $, %, #). Currently @containerid only accepts NMTOKEN values, which can't include such special characters. I propose relaxing the data type for @containerid from NMTOKEN to string to accept special characters.

rockivist commented 6 years ago

@noahgh221 Check out ead3.rng in the issue_512 branch. Do your barcodes validate in containerid now?

noahgh221 commented 6 years ago

Yes! Barcodes with special characters in containerid now validate against this modified schema. Thanks.

rockivist commented 6 years ago

Good. I consider this a bug, not a feature request, so I don't think it's something that needs to be vetted with TS-EAS at large. That said I have probably already been removed from that mailing list, so could you send out a heads up to the committee that we have another bug that has been fixed and can be included in the 1.1 release?

I'll issue a pull request.

noahgh221 commented 6 years ago

Will do. Thanks.

fordmadox commented 6 years ago

Fixed by Mike, and this is now available in all 6 versions of the schema (which are still in testing, but should hopefully be in the master branch soon)

rockivist commented 6 years ago

@fordmadox Looks good in all six 1.1.2 release candidate schemas.