search

SAA-SDT / EAD3

https://www.loc.gov/ead/index.html
Creative Commons Zero v1.0 Universal
80 stars 25 forks source link

<c12> not validating in schema #523

Closed karinbredenberg closed 4 years ago

karinbredenberg commented 5 years ago

Creator of issue

  1. Kelly Revak, Library of Congress
  2. e-mails: kere@loc.gov; cconr@loc.gov

The issue relates to

Reporting a bug

We looked into the schema (ead3.xsd) and it looks like <c12> wasn't defined.
The other component levels read something like this:

`

` But the `` element is empty: `` ## Suggested Solution * Text: We did a test and changed the c12 bit in the ead3.xsd to be this: ` ` ...And the `` component in our test EAD3 did validate. (we are not experts in schema writing so this may be missing something or otherwise incorrect. We assumed that it can't contain any further component levels, so took out `` ## Steps to Reproduce (for bugs) 1. create an EAD3 with a `` element with content. It will not validate if the ead3 schema is associated. ## Context * Text: unable to test `` in LC EAD3 implementation. ## Your Environment can be a clue to a bug * Version used: Oxygen XML editor 20.1 and EAD3 v 1.1 * Environment name and version (e.g. Chrome 39, node.js 5.4): * Operating System and version (desktop or mobile):
kerstarno commented 4 years ago

In their meeting on 23 September 2019, TS-EAS EAD team decided that this bug should be corrected. Issue is therefore assigned to the leads of the Schema team for next steps.

fordmadox commented 4 years ago

Just a note that I've checked into this issue, and it happens due to the "deglobalize.xsl" transformation process.

@tcatapano : i plan to set up a test before making any changes, but do you remember exactly why that step was necessary?

tcatapano commented 4 years ago

@fordmadox: it's been a while, but per the comment at https://github.com/SAA-SDT/EAD3/blob/2f4f1d7bfe35ffd171260d8b1177e5bb0616a86f/inprocess/deglobalize/deglobalize.xsl#L14 the main function of the deglobalize.xsl transformation is to wrap definitions of any element not named 'ead' which is a child of 'xsd:schema' in 'xsd:complexType' elements so that they will not be available as root elements. It's basically a cleanup of the result of the trang conversion from rng.

fordmadox commented 4 years ago

Thanks, @tcatapano! I'll keep that in mind when I add a patch for this issue.

fordmadox commented 4 years ago

Closing this out since the change has been merged.