Links to new elements break due to "(revised in 2010 Revised)" being part of the URL - Githubissues

SAA-SDT / EAS-TagLibraries

Tag Libraries for Encoded Archival Description Version 3 and Encoded Archival Context: Corporate Bodies, Persons, and Families

7 stars 5 forks source link

Links to new elements break due to "(revised in 2010 Revised)" being part of the URL #26

Closed kerstarno closed 5 years ago

kerstarno commented 5 years ago

Creator of issue

Kerstin Arnold
Archives Portal Europe Foundation
Email: kerstin.arnold.berlin@gmail.com
GitHub: @kerstarno

The issue relates to

[ ] EAC-CPF schema issue
[x] EAC-CPF Tag Library issue
[ ] EAD schema issue
[x] EAD Tag Library issue
[ ] Schema issue
[x] Tag Library issue
[ ] Suggestions for all schemas
[x] Suggestions for all Tag Libraries
[ ] Other

Wanted change/feature

Text:

Reporting a bug

Text: In the same context as issue #62, I found that some links to new or revised elements in the Tag Library include the note "(revised in 2010 Revised)" in their URL-s. E.g. https://eac.staatsbibliothek-berlin.de/schema/taglibrary/cpfTagLibrary2018_EN.html#elem-rightsDeclaration%20(revised%20in%202010%20Revised). This means, that these links don't work, but clicking will not result in any action.

Suggested Solution

Text: Probably to do with the encoding in TEI, so that could be worth reviewing. URL-s should end with the name of the element, i.e. https://eac.staatsbibliothek-berlin.de/schema/taglibrary/cpfTagLibrary2018_EN.html#elem-rightsDeclaration.
As far as I can see, this refers to Link to <rightsDeclaration> in the description of <abbreviation> Link to <rightsDeclaration> in the description of <citation> Link to <sources> in the description of <control> Link to <source> in the description of <descriptiveNote>

Steps to Reproduce (for bugs)

1. 2. 3. 4.

Context

Text:

Your Environment can be a clue to a bug

Version used:
Environment name and version (e.g. Chrome 39, node.js 5.4):
Operating System and version (desktop or mobile):

kerstarno commented 5 years ago

Moved here from the EAC subteam area, as it is also an issue for the EAD3 Tag Library. Seems to relate to the following elements in EAD3:

Link to <rightsdeclaration> in the description of <control>
Link to @localtype in the description of <conventiondeclaration>
Link to <part> in the description of <date>
Link to <ref> in the description of <part>
Link to @render in the description of <quote>

alexduryee commented 5 years ago

Thanks for finding this - resolved in #30.