SAA-SDT / EAS-TagLibraries

Tag Libraries for Encoded Archival Description Version 3 and Encoded Archival Context: Corporate Bodies, Persons, and Families
7 stars 5 forks source link

EAD3 Tag Library indexentry example #69

Closed karinbredenberg closed 2 years ago

karinbredenberg commented 4 years ago

Creator of issue

  1. Emma Esperon, Library of Congress, eesp@loc.gov

The issue relates to

Wanted change/feature

I was browsing indexentry and noticed a stray angle bracket. Not a deal breaker, just not a great example of good code.

12th Air Force Photo >LOT 13105 15th Air Force Command: LOT 13105 ## Reporting a bug * Text: ## Suggested Solution * Text: Delete the extra angle bracket in the html and PDF version and all will be good! When they're updated, let Glenn Gardner know at LC and we'll update the EAD site. Thanks! ## Steps to Reproduce (for bugs) 1. 2. 3. 4. ## Context * Text: ## Your Environment can be a clue to a bug * Version used: * Environment name and version (e.g. Chrome 39, node.js 5.4): * Operating System and version (desktop or mobile):
kerstarno commented 3 years ago

@alexduryee - while I can see the change having been made in https://github.com/SAA-SDT/EAS-TagLibraries/pull/72/files, the stray angle bracket still shows in the draft PDF for the TL.

It's the first <indexentry> example for both <index> and <indexentry>:

<indexentry>
  <name>
    <part>12th Air Force Photo</part>
  </name>
  <ref target="LOT13105" actuate="onrequest" show="replace">>LOT 13105</ref>
</indexentry>
alexduryee commented 2 years ago

Closing due to issue being fixed in https://github.com/SAA-SDT/EAS-TagLibraries/commit/ebf2310fe4193e69559dc57de315734f9dec708a