SAA-SDT / EAS-TagLibraries

Tag Libraries for Encoded Archival Description Version 3 and Encoded Archival Context: Corporate Bodies, Persons, and Families
7 stars 5 forks source link

Repeatability for <ref> and <ptr> misleading in EAD3 tag library #85

Closed erussey closed 2 years ago

erussey commented 3 years ago

In the EAD3 tag library description for <ref>, the availability of the tag is listed as optional and repeatable within all parent elements except <ptrgrp>. This is incorrect for <indexentry> (which is listed as one of the elements that <ref> can occur within), which requires an intermediate <ptrgrp> for multiple <ref>.

Creator of issue

  1. Elizabeth Roke
  2. Emory University
  3. erussey@emory.edu

The issue relates to

Wanted change/feature

Reporting a bug

Suggested Solution

Steps to Reproduce (for bugs)

1. 2. 3. 4.

Context

Your Environment can be a clue to a bug

kerstarno commented 3 years ago

Well spotted, @erussey - thanks very much.

<indexentry> indeed can either have a single <ref> or a single <ptr> or it can use <ptrgrp> to allow for either of <ref> or <ptr> to be repeated. The same misleading repeatability statement therefore also is effective for <ptr>.

@alexduryee - could you please have a look at this and prepare a correction of the "Availability" section for both, <ref> and <ptr> to state the following:

Within <ptrgrp>: One of <ptr> or <ref> is required, repeatable Within <indexentry>: Optional, not repeatable Within all other parents: Optional, repeatable

alexduryee commented 2 years ago

Fix is live on development - should we close this?