search

SAAVY / magpie

http://projectmagpie.github.io
MIT License
7 stars 0 forks source link

Wikipedia description bug fix #104

Closed samiyaakhtar closed 8 years ago

samiyaakhtar commented 8 years ago

Some changes in wikipedia api caused this stuff to break, should work now.

AliceYuan commented 8 years ago

r+, we should write some tests that check to make sure we're not out of date with the apis

samiyaakhtar commented 8 years ago

Something's messed up with tests entirely, it was working fine this morning. I'll send another commit soon

AliceYuan commented 8 years ago

ah @samiyaakhtar, it was probably my refactor changes that were sent in. you should be making sure that the tests patch generic_fetch_content. If you want you can wait a bit so I can write an example unit test to show you how to write it

samiyaakhtar commented 8 years ago

Yup it's the refactoring you merged in last night, i'll have to redo the main bug fix again too. I'll work on this later today

AliceYuan commented 8 years ago

This shouldn't be needed anymore see #107 it has the wikipedia changes