search

SAAVY / magpie

http://projectmagpie.github.io
MIT License
7 stars 0 forks source link

Revert "Revert "Remove beautiful soup + refactor metadata code"" #107

Closed AliceYuan closed 8 years ago

AliceYuan commented 8 years ago

98

Fixes refactor (had old code without new wikipedia code) has #104

codecov-io commented 8 years ago

Current coverage is 40.27%

Merging #107 into master will decrease coverage by -21.99% as of 405f86a

@@            master    #107   diff @@
======================================
  Files           24      24       
  Stmts          636     653    +17
  Branches         0       0       
  Methods          0       0       
======================================
- Hit            396     263   -133
  Partial          0       0       
- Missed         240     390   +150

Review entire Coverage Diff as of 405f86a

Powered by Codecov. Updated on successful CI builds.

AliceYuan commented 8 years ago

@samiyaakhtar can you review this? has the wikipedia changes in https://github.com/SAAVY/magpie/commit/ee2e0ac0a94964b3b6f7b3b021d4c45c6b1810c8

samiyaakhtar commented 8 years ago

r+ I'll work on tests after all of this is merged in