search

SAAVY / magpie

http://projectmagpie.github.io
MIT License
7 stars 0 forks source link

Multiple src queries #137

Closed samiyaakhtar closed 8 years ago

samiyaakhtar commented 8 years ago

Issue #131

codecov-io commented 8 years ago

Current coverage is 36.69%

Merging #137 into master will decrease coverage by -0.55% as of 5f38eab

@@            master    #137   diff @@
======================================
  Files           26      26       
  Stmts          776     793    +17
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            289     291     +2
  Partial          0       0       
- Missed         487     502    +15

Review entire Coverage Diff as of 5f38eab

Powered by Codecov. Updated on successful CI builds.

samiyaakhtar commented 8 years ago

@AliceYuan it doesnt return a list when there is only 1, i can show you the outputs i get for 1 and 2 requests if you want.

samiyaakhtar commented 8 years ago

I'll make another commit after cleaning up the way you asked, Alice.

samiyaakhtar commented 8 years ago

Done cleaning up @AliceYuan @MeenuV

AliceYuan commented 8 years ago

it looks fine to me, can you add some documentation in the readme on how to maple multiple url requests? and what the structure of the response would look like

samiyaakhtar commented 8 years ago

Done adding documentation, and the tiny changes @AliceYuan @MeenuV

AliceYuan commented 8 years ago

looks good! r+