search

SAAVY / magpie

http://projectmagpie.github.io
MIT License
7 stars 0 forks source link

Integration tests #139

Closed samiyaakhtar closed 8 years ago

samiyaakhtar commented 8 years ago

Issue #138

codecov-io commented 8 years ago

Current coverage is 84.99%

Merging #139 into master will increase coverage by +48.30% as of a1f6db4

@@            master    #139   diff @@
======================================
  Files           26      26       
  Stmts          793     793       
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            291     674   +383
  Partial          0       0       
+ Missed         502     119   -383

Review entire Coverage Diff as of a1f6db4

Powered by Codecov. Updated on successful CI builds.

AliceYuan commented 8 years ago

looking good! added comments about missing some test cases

samiyaakhtar commented 8 years ago

Made the suggested changes @AliceYuan

MeenuV commented 8 years ago

Small nitpick, but otherwise, +1

MeenuV commented 8 years ago

:+1:

samiyaakhtar commented 8 years ago

Coverage here we come